Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W3C Errors because of missing type attribute #70

Open
georgringer opened this issue Jan 22, 2024 · 0 comments · May be fixed by #71
Open

W3C Errors because of missing type attribute #70

georgringer opened this issue Jan 22, 2024 · 0 comments · May be fixed by #71

Comments

@georgringer
Copy link
Contributor

Even though w3c validation is not that important anymore there was a client request to fix errors

Error: A source element that has a following sibling source element or img element with a srcset attribute must have a media attribute and/or type attribute.

[From line 813, column 34; to line 813, column 211](https://validator.w3.org/nu/#l813c211)

 <picture><source srcset="/fileadmin/_processed_/3/3/csm_Screen_MB_PHONE_skew_bewerbung_71fd9e0992.png 1x, /fileadmin/_processed_/3/3/csm_Screen_MB_PHONE_skew_bewerbung_2ec251f74c.png 2x"><sourc

don't ask me about details of the validation - just wanna fix it - PR incoming
georgringer added a commit to georgringer/melon-images that referenced this issue Jan 22, 2024
@georgringer
[BUGFIX] Always populate type attribute
b3db824 
Always fill type attribute

Resolves: smichaelsen#70
@georgringer georgringer linked a pull request Jan 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Always populate type attribute georgringer/melon-images
1 participant
@georgringer