New Pint configuration (#16)

smortexa · web-flow · commit 529322c784e4 · 2023-01-19T17:20:02.000+03:30
* Improve Pint configuration

* Fix code-style with new Pint configuration
diff --git a/pint.json b/pint.json
@@ -0,0 +1,45 @@
+{
+  "preset": "laravel",
+  "notPath": [
+    "app/Services/HtmlMinifier.php"
+  ],
+  "rules": {
+    "align_multiline_comment": true,
+    "array_indentation": true,
+    "array_syntax": true,
+    "blank_line_after_namespace": true,
+    "blank_line_after_opening_tag": true,
+    "combine_consecutive_issets": true,
+    "combine_consecutive_unsets": true,
+    "concat_space": true,
+    "declare_parentheses": true,
+    "declare_strict_types": true,
+    "explicit_string_variable": false,
+    "final_class": false,
+    "final_internal_class": false,
+    "fully_qualified_strict_types": true,
+    "global_namespace_import": {
+      "import_classes": true,
+      "import_constants": true,
+      "import_functions": true
+    },
+    "is_null": true,
+    "lambda_not_used_import": true,
+    "logical_operators": true,
+    "mb_str_functions": true,
+    "method_chaining_indentation": true,
+    "modernize_strpos": true,
+    "new_with_braces": true,
+    "no_empty_comment": true,
+    "not_operator_with_space": true,
+    "ordered_traits": true,
+    "protected_to_private": true,
+    "simplified_if_return": true,
+    "strict_comparison": true,
+    "ternary_to_null_coalescing": true,
+    "trim_array_spaces": true,
+    "use_arrow_functions": true,
+    "void_return": true,
+    "yoda_style": true
+  }
+}
diff --git a/src/ArkitectServiceProvider.php b/src/ArkitectServiceProvider.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect;
 
 use Illuminate\Support\ServiceProvider;
diff --git a/src/Console/MakeArkitectRule.php b/src/Console/MakeArkitectRule.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Console;
 
 use Illuminate\Console\GeneratorCommand;
diff --git a/src/Console/TestArchitecture.php b/src/Console/TestArchitecture.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Console;
 
 use Illuminate\Console\Command;
@@ -27,7 +29,7 @@ public function handle(): int
         $process = Process::fromShellCommandline($command);
         $process->setTimeout(60);
         $process->setTty(Process::isTtySupported());
-        $process->run(function ($type, $line) use (&$process) {
+        $process->run(function ($type, $line) use (&$process): void {
             match ($type) {
                 $process::ERR => $this->line($line),
                 default => $this->info($line)
diff --git a/src/Contracts/RuleContract.php b/src/Contracts/RuleContract.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Contracts;
 
 use Arkitect\Rules\DSL\ArchRule;
diff --git a/src/CreateApplication.php b/src/CreateApplication.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect;
 
 use Illuminate\Contracts\Console\Kernel;
@@ -11,7 +13,7 @@ class CreateApplication
 
     public static function app()
     {
-        if (! is_null(static::$app)) {
+        if (null !== static::$app) {
             return static::$app;
         }
 
diff --git a/src/RuleLoader.php b/src/RuleLoader.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect;
 
 use Illuminate\Support\Arr;
diff --git a/src/Rules/BaseRule.php b/src/Rules/BaseRule.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules;
 
 use Arkitect\ClassSet;
diff --git a/src/Rules/Extending/CommandsExtending.php b/src/Rules/Extending/CommandsExtending.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Extending;
 
 use Arkitect\Expression\ForClasses\Extend;
diff --git a/src/Rules/Extending/ControllersExtending.php b/src/Rules/Extending/ControllersExtending.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Extending;
 
 use Arkitect\Expression\ForClasses\Extend;
diff --git a/src/Rules/Extending/ExceptionsExtending.php b/src/Rules/Extending/ExceptionsExtending.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Extending;
 
 use Arkitect\Expression\ForClasses\Extend;
diff --git a/src/Rules/Extending/FactoriesExtending.php b/src/Rules/Extending/FactoriesExtending.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Extending;
 
 use Arkitect\Expression\ForClasses\Extend;
diff --git a/src/Rules/Extending/MailsExtending.php b/src/Rules/Extending/MailsExtending.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Extending;
 
 use Arkitect\Expression\ForClasses\Extend;
diff --git a/src/Rules/Extending/ModelsExtending.php b/src/Rules/Extending/ModelsExtending.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Extending;
 
 use Arkitect\Expression\ForClasses\Extend;
diff --git a/src/Rules/Extending/NotificationsExtending.php b/src/Rules/Extending/NotificationsExtending.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Extending;
 
 use Arkitect\Expression\ForClasses\Extend;
diff --git a/src/Rules/Extending/ProvidersExtending.php b/src/Rules/Extending/ProvidersExtending.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Extending;
 
 use Arkitect\Expression\ForClasses\Extend;
diff --git a/src/Rules/Extending/RequestsExtending.php b/src/Rules/Extending/RequestsExtending.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Extending;
 
 use Arkitect\Expression\ForClasses\Extend;
diff --git a/src/Rules/Extending/ResourceCollectionsExtending.php b/src/Rules/Extending/ResourceCollectionsExtending.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Extending;
 
 use Arkitect\Expression\ForClasses\Extend;
diff --git a/src/Rules/Extending/ResourcesExtending.php b/src/Rules/Extending/ResourcesExtending.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Extending;
 
 use Arkitect\Expression\ForClasses\Extend;
diff --git a/src/Rules/Extending/SeedersExtending.php b/src/Rules/Extending/SeedersExtending.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Extending;
 
 use Arkitect\Expression\ForClasses\Extend;
diff --git a/src/Rules/Extending/ViewsExtending.php b/src/Rules/Extending/ViewsExtending.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Extending;
 
 use Arkitect\Expression\ForClasses\Extend;
diff --git a/src/Rules/Implementing/CastsImplementing.php b/src/Rules/Implementing/CastsImplementing.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Implementing;
 
 use Arkitect\Expression\ForClasses\Implement;
diff --git a/src/Rules/Implementing/JobsImplementing.php b/src/Rules/Implementing/JobsImplementing.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Implementing;
 
 use Arkitect\Expression\ForClasses\Implement;
diff --git a/src/Rules/Implementing/RulesImplementing.php b/src/Rules/Implementing/RulesImplementing.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Implementing;
 
 use Arkitect\Expression\ForClasses\Implement;
diff --git a/src/Rules/Implementing/ScopesImplementing.php b/src/Rules/Implementing/ScopesImplementing.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Implementing;
 
 use Arkitect\Expression\ForClasses\Implement;
diff --git a/src/Rules/Naming/BuildersNaming.php b/src/Rules/Naming/BuildersNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/ChannelsNaming.php b/src/Rules/Naming/ChannelsNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/ContractsNaming.php b/src/Rules/Naming/ContractsNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/ControllersNaming.php b/src/Rules/Naming/ControllersNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/ExceptionsNaming.php b/src/Rules/Naming/ExceptionsNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/FactoriesNaming.php b/src/Rules/Naming/FactoriesNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/MailsNaming.php b/src/Rules/Naming/MailsNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/NotificationsNaming.php b/src/Rules/Naming/NotificationsNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/ObserversNaming.php b/src/Rules/Naming/ObserversNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/PoliciesNaming.php b/src/Rules/Naming/PoliciesNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/ProvidersNaming.php b/src/Rules/Naming/ProvidersNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/RepositoriesNaming.php b/src/Rules/Naming/RepositoriesNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/RequestsNaming.php b/src/Rules/Naming/RequestsNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/ResourcesNaming.php b/src/Rules/Naming/ResourcesNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/ScopesNaming.php b/src/Rules/Naming/ScopesNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/Rules/Naming/SeedersNaming.php b/src/Rules/Naming/SeedersNaming.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Mortexa\LaravelArkitect\Rules\Naming;
 
 use Arkitect\Expression\ForClasses\HaveNameMatching;
diff --git a/src/config/config.php b/src/config/config.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Mortexa\LaravelArkitect\Rules\Extending\CommandsExtending;
 use Mortexa\LaravelArkitect\Rules\Extending\ControllersExtending;
 use Mortexa\LaravelArkitect\Rules\Extending\ExceptionsExtending;
diff --git a/tests/Feature/MakeArkitectRuleCommandTest.php b/tests/Feature/MakeArkitectRuleCommandTest.php
diff --git a/tests/Feature/RuleLoaderTest.php b/tests/Feature/RuleLoaderTest.php
diff --git a/tests/Pest.php b/tests/Pest.php
diff --git a/tests/TestCase.php b/tests/TestCase.php

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,7 @@`
`1`	`1`	`<?php`
`2`	`2`
	`3`	`+declare(strict_types=1);`
	`4`	`+`
`3`	`5`	`namespace Mortexa\LaravelArkitect;`
`4`	`6`
`5`	`7`	`use Illuminate\Contracts\Console\Kernel;`
`@@ -11,7 +13,7 @@ class CreateApplication`
`11`	`13`
`12`	`14`	`public static function app()`
`13`	`15`	`{`
`14`		`- if (! is_null(static::$app)) {`
	`16`	`+ if (null !== static::$app) {`
`15`	`17`	`return static::$app;`
`16`	`18`	`}`
`17`	`19`