Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Location in acceptance notification #15480

Open
swift2512 opened this issue Sep 10, 2024 · 3 comments
Open

[Feature Request]: Location in acceptance notification #15480

swift2512 opened this issue Sep 10, 2024 · 3 comments

Comments

@swift2512
Copy link

swift2512 commented Sep 10, 2024

Is your feature request related to a problem? Please describe.

Larger companies can have multiple offices in different locations (buildings, cities, etc.) and handful of employees responsible for assets (ADMINS) in their location. Currently, there's no way to send an acceptance/decline email notification to the admin, who checked-out item to the user. (You can add CC email in Admin > Notifications, but this would get ugly with thousands of assets and dozens of admins)

Describe the solution you'd like

Ideal way: Snipe-IT sends a copy of acceptance/decline email to person who checked-out that item to the user.
(If Snipe-IT can pull Notification email from db, it could also pull admins email and add it as cc on the fly)

Describe alternatives you've considered

Current location of the user is written in the acceptance/decline email.
(This way, you could at least set email rules on your mail server or client.)

Additional context

No response

@swift2512
Copy link
Author

swift2512 commented Sep 11, 2024

A quick fix. Looks like it works and doesn't break anything, but I may be terribly wrong. :D
File: resources/views/notifications/markdown/asset-acceptance.blade.php
Above acceptance date added these lines

@if (isset($user->location))
| **{{ trans('general.location') }}** | {{ $user->location->name }} |
@endif

Result
image

@snipe
Copy link
Owner

snipe commented Sep 11, 2024

Currently, there's no way to send an acceptance/decline email notification to the admin, who checked-out item to the user.

That's not what it's intended for. It's intended for the end-user to accept (on record) that they have received the asset. The CC option is just in case the admin wants to be copied on it, but I don't see why the admin would be accepting or denying the item, since they checked it out in the first place.

@swift2512
Copy link
Author

Currently, there's no way to send an acceptance/decline email notification to the admin, who checked-out item to the user.

That's not what it's intended for. It's intended for the end-user to accept (on record) that they have received the asset. The CC option is just in case the admin wants to be copied on it, but I don't see why the admin would be accepting or denying the item, since they checked it out in the first place.
Sorry for my English. :) I meant email alert that is being sent to the email addresses set in Admin > Notifications, after user accepts/declines an item. (Message, like the one in my previous message.)

Organizations may have thousands of employees in different offices and cities and dozens of admins responsible for different groups/types of items. When this 'accept/decline email' is sent to all admins, there's no easy way to tell where that user works. Admin would need to login to Snipe-IT, look for that user just to find out, that it's not from his office/city and not in his responsibility.
If users location is shown in the email, admin can quickly see if he needs to act or can disregard the message. Also, location would allow Admins to easily create rules in their mail clients ('if email is from:, has 'Location' in the body - move to this folder, play this sound...')

Even if this feature won't end-up in release, I will manually edit asset-acceptance.blade.php to include users location, because it will make life easier for me and dozens of other admins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants