Skip to content

Commit 6a21bb5

Browse files
Update bundlemon to version 3 to fix CI failures on change check (#1469)
* Update bundlemon to version 3 to fix CI failures on change check * Add permissions for check workflow * Only run when triggered from the same repo * Tweak max size limits # 50-character subject line # * Present tense # # 72-character wrapped longer description. This should answer: # * Why was this change necessary? # * How does it address the problem? # * Are there any side effects?
1 parent 16e01ee commit 6a21bb5

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

.bundlemonrc.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
},
2323
{
2424
"path": "./libraries/browser-tracker-core/dist/index.module.js",
25-
"maxSize": "25kb",
25+
"maxSize": "26kb",
2626
"maxPercentIncrease": 10
2727
},
2828
{
@@ -31,5 +31,5 @@
3131
"maxPercentIncrease": 10
3232
}
3333
],
34-
"reportOutput": ["github"]
34+
"reportOutput": []
3535
}

.github/workflows/change_check.yml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@ jobs:
66
check:
77
runs-on: ubuntu-latest
88

9+
permissions:
10+
contents: read
11+
pull-requests: write
12+
checks: write
13+
914
env:
1015
BROWSERSLIST_IGNORE_OLD_DATA: true
1116

@@ -55,7 +60,10 @@ jobs:
5560
run: api-extractor run
5661

5762
- name: Check bundle size using bundlemon
58-
run: npx bundlemon@1.4.0
63+
if: github.event.pull_request.head.repo.full_name == github.repository
64+
run: npx bundlemon@3
5965
env:
60-
BUNDLEMON_PROJECT_ID: 630fceda4ed824a9d3733ec0
61-
CI_COMMIT_SHA: ${{github.event.pull_request.head.sha || github.sha}}
66+
BUNDLEMON_PROJECT_ID: 69e5e44cf67d5035af9fd1c0
67+
BUNDLEMON_PROJECT_APIKEY: ${{ secrets.BUNDLEMON_PROJECT_APIKEY }}
68+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
69+
CI_COMMIT_SHA: ${{ github.event.pull_request.head.sha || github.sha }}

0 commit comments

Comments
 (0)