Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Detect github-enterprise URL before migrating it or allow explicit definition of github integration type to ignore github-enterprise integrations #4

Open
1 task done
unitysipu opened this issue May 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@unitysipu
Copy link

unitysipu commented May 10, 2024

Is there an existing feature request for this?

  • I have searched the existing feature requests

Description

The default settings of the tool assume github-enterprise integration is used. Our company has multiple instances of github enterprise server installed, so it's safe to assume most github-enterprise integrations are NOT going towards github.com. Also because snyk only allows one integration type per organization, that itself poses some significant limitation to our use cases.

We are now migrating to github cloud app to get rid of the personal github integrations, but we can't blanket migrate github-enterprise integrations to the github cloud app as they are likely linked to our internal enterprise server instances.

  1. Instead of defaulting to github-enterprise with an option to include github, there should be a mechanism to explicitly specify specific integration type to migrate to make it easy to exclude github-enterprise without hacking the code and then having the option to migrate all.

  2. Advanced method could be to actually detect the target of the github enterprise integration and if it's not pointing to github.com, ignore it. It's not super clear how you can get this information using the public snyk API at the moment.

The public integration settings API does not include the account settings portion of the github enterprise integration which would contain the actual URL of the instance, which is far from optimal for this use-case. https://snyk.docs.apiary.io/#reference/integrations/integration-settings/retrieve

Additional Information

No response

@unitysipu unitysipu added the enhancement New feature or request label May 10, 2024
@unitysipu
Copy link
Author

i'm working on this feature and i'll create a pull request for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant