Modernize code + expanded test coverage.

Author: samuel-williams-shopify

.github/copilot-instructions.md

@@ -2,7 +2,7 @@
 
 ## Use Agent Context
 
-When working on this project, consult the `agent.md` file for project-specific guidelines, architecture decisions, and development patterns. This file contains curated information that will help you make better decisions aligned with the project's goals and standards.
+When working on this project, consult the `agents.md` file for project-specific guidelines, architecture decisions, and development patterns. This file contains curated information that will help you make better decisions aligned with the project's goals and standards.
 
 If the file does not exist, you will need to install it, by running the following command:
 

.gitignore

@@ -1,4 +1,4 @@
-/agent.md
+/agents.md
 /.context
 /.bundle
 /pkg

.rubocop.yml

@@ -1,12 +1,23 @@
 plugins:
+  - rubocop-md
   - rubocop-socketry
 
 AllCops:
   DisabledByDefault: true
 
+# Socketry specific rules:
+
 Layout/ConsistentBlankLineIndentation:
   Enabled: true
 
+Layout/BlockDelimiterSpacing:
+  Enabled: true
+
+Style/GlobalExceptionVariables:
+  Enabled: true
+
+# General Layout rules:
+
 Layout/IndentationStyle:
   Enabled: true
   EnforcedStyle: tabs
@@ -33,6 +44,9 @@ Layout/BeginEndAlignment:
   Enabled: true
   EnforcedStyleAlignWith: start_of_line
 
+Layout/RescueEnsureAlignment:
+  Enabled: true
+
 Layout/ElseAlignment:
   Enabled: true
 
@@ -41,10 +55,15 @@ Layout/DefEndAlignment:
 
 Layout/CaseIndentation:
   Enabled: true
+  EnforcedStyle: end
 
 Layout/CommentIndentation:
   Enabled: true
 
+Layout/FirstHashElementIndentation:
+  Enabled: true
+  EnforcedStyle: consistent
+
 Layout/EmptyLinesAroundClassBody:
   Enabled: true
 

context/best-practices.md

@@ -14,8 +14,8 @@ Create a single top-level `service.rb` file as your main entry point:
 #!/usr/bin/env async-service
 
 # Load your service configurations
-require_relative 'lib/my_library/environment/web_environment'
-require_relative 'lib/my_library/environment/worker_environment'
+require_relative "lib/my_library/environment/web_environment"
+require_relative "lib/my_library/environment/worker_environment"
 
 service "web" do
 	include MyLibrary::Environment::WebEnvironment
@@ -159,9 +159,9 @@ module WebEnvironment
 	def port
 		3000
 	end
-
+	
 	def host
-		'0.0.0.0'
+		"0.0.0.0"
 	end
 end
 
@@ -172,7 +172,7 @@ module WorkerEnvironment
 	end
 
 	def queue_name
-		'default'
+		"default"
 	end
 
 	def count
@@ -254,7 +254,7 @@ class WebService < Async::Service::ContainerService
 
 		super
 	end
-
+	
 	def stop
 		@endpoint&.close
 	end
@@ -302,7 +302,7 @@ describe MyLibrary::Service::WebService do
 	before do
 		controller.start
 	end
-
+	
 	after do
 		controller.stop
 	end

context/getting-started.md

@@ -29,7 +29,7 @@ Create a simple service that runs continuously:
 ```ruby
 #!/usr/bin/env async-service
 
-require 'async/service'
+require "async/service"
 
 class HelloService < Async::Service::Generic
 	def setup(container)
@@ -99,7 +99,7 @@ You can define multiple services in a single configuration file:
 ```ruby
 #!/usr/bin/env async-service
 
-require 'async/service'
+require "async/service"
 
 class WebService < Async::Service::Generic
 	def setup(container)
@@ -141,7 +141,7 @@ end
 You can also create and run services programmatically:
 
 ```ruby
-require 'async/service'
+require "async/service"
 
 configuration = Async::Service::Configuration.build do
 	service "my-service" do

context/service-architecture.md

@@ -439,11 +439,11 @@ module ContainerEnvironment
 	def count
 		4
 	end
-
+	
 	def restart
 		true
 	end
-
+	
 	def health_check_timeout
 		30
 	end

examples/ipc/client.rb

@@ -23,30 +23,30 @@ def setup(container)
 		container.run(count: 1, restart: true) do |instance|
 			socket_path = evaluator.ipc_socket_path
 
-			Console.info(self) {"IPC Client starting - will connect to #{socket_path}"}
+			Console.info(self){"IPC Client starting - will connect to #{socket_path}"}
 			instance.ready!
 
 			while true
 				begin
 					# Connect to server
 					client = UNIXSocket.new(socket_path)
-					Console.info(self) {"Connected to server"}
+					Console.info(self){"Connected to server"}
 
 					# Read response
 					response = client.readline.chomp
 					puts "📨 Received: #{response}"
 
 					client.close
-					Console.info(self) {"Connection closed"}
+					Console.info(self){"Connection closed"}
 
 					# Wait before next connection
 					sleep(2)
 
 				rescue Errno::ENOENT
-					Console.warn(self) {"Server socket not found at #{socket_path}, retrying..."}
+					Console.warn(self){"Server socket not found at #{socket_path}, retrying..."}
 					sleep(3)
 				rescue Errno::ECONNREFUSED
-					Console.warn(self) {"Connection refused, server may not be ready"}
+					Console.warn(self){"Connection refused, server may not be ready"}
 					sleep(3)
 				rescue => error
 					Console.error(self, error)

examples/ipc/server.rb

@@ -28,21 +28,21 @@ def setup(container)
 			# Create Unix domain socket server
 			server = UNIXServer.new(socket_path)
 
-			Console.info(self) {"IPC Server listening on #{socket_path}"}
+			Console.info(self){"IPC Server listening on #{socket_path}"}
 			instance.ready!
 
 			begin
 				while true
 					# Accept incoming connections
 					client = server.accept
-					Console.info(self) {"Client connected from PID #{client.peereid[0]}"}
+					Console.info(self){"Client connected from PID #{client.peereid[0]}"}
 
 					# Send greeting with timestamp
 					timestamp = Time.now.strftime("%H:%M:%S")
 					client.write("Hello World at #{timestamp}\n")
 					client.close
 
-					Console.info(self) {"Sent greeting and closed connection"}
+					Console.info(self){"Sent greeting and closed connection"}
 				end
 			rescue => error
 				Console.error(self, error)

examples/ipc/service.rb

@@ -6,11 +6,11 @@
 
 require "socket"
 require "async"
-require "async/service/container_service"
-require "async/service/container_environment"
+require "async/service/managed/service"
+require "async/service/managed/environment"
 
 # Server service that listens on a Unix domain socket and responds with "Hello World"
-class IPCServer < Async::Service::ContainerService
+class IPCServer < Async::Service::Managed::Service
 	def run(instance, evaluator)
 		socket_path = evaluator.ipc_socket_path
 
@@ -20,20 +20,20 @@ def run(instance, evaluator)
 		# Create Unix domain socket server
 		server = UNIXServer.new(socket_path)
 
-		Console.info(self) {"IPC Server listening on #{socket_path}"}
+		Console.info(self){"IPC Server listening on #{socket_path}"}
 		instance.ready!
 
 		begin
 			while true
 				# Accept incoming connections
 				client = server.accept
-				Console.info(self) {"Client connected"}
+				Console.info(self){"Client connected"}
 
 				# Send greeting
 				client.write("Hello World\n")
 				client.close
 
-				Console.info(self) {"Sent greeting and closed connection"}
+				Console.info(self){"Sent greeting and closed connection"}
 			end
 		rescue => error
 			Console.error(self, error)
@@ -47,12 +47,12 @@ def run(instance, evaluator)
 end
 
 # Client service that periodically connects to the server
-class IPCClient < Async::Service::ContainerService
+class IPCClient < Async::Service::Managed::Service
 	def run(instance, evaluator)
 		socket_path = evaluator.ipc_socket_path
 		timeout = evaluator.ipc_connection_timeout
 
-		Console.info(self) {"IPC Client starting - will connect to #{socket_path}"}
+		Console.info(self){"IPC Client starting - will connect to #{socket_path}"}
 		instance.ready!
 
 		Async do |task|
@@ -63,20 +63,20 @@ def run(instance, evaluator)
 
 					# Connect to server
 					client = UNIXSocket.new(socket_path)
-					Console.info(self) {"Connected to server"}
+					Console.info(self){"Connected to server"}
 
 					# Read response
 					response = client.readline.chomp
 					puts "Received from server: #{response}"
 
 					client.close
-					Console.info(self) {"Connection closed"}
+					Console.info(self){"Connection closed"}
 
 					# Wait before next connection
 					task.sleep(3)
 
 				rescue Errno::ENOENT
-					Console.warn(self) {"Server socket not found at #{socket_path}, retrying..."}
+					Console.warn(self){"Server socket not found at #{socket_path}, retrying..."}
 					task.sleep(2)
 				rescue => error
 					Console.error(self, error)
@@ -88,7 +88,7 @@ def run(instance, evaluator)
 end
 
 module IPCEnvironment
-	include Async::Service::ContainerEnvironment
+	include Async::Service::Managed::Environment
 
 	def ipc_socket_path
 		File.expand_path("service.ipc", Dir.pwd)

gems.rb

@@ -23,8 +23,11 @@
 	gem "decode"
 
 	gem "rubocop"
+	gem "rubocop-md"
 	gem "rubocop-socketry"
 
+	gem "sus-fixtures-async"
+	
 	gem "bake"
 	gem "bake-test"
 	gem "bake-test-external"