[Fabric LA] Fix maybeDropAncestors
condition.
#6663
+367
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the
maybeDropAncestors
function we can remove the view if it has no remaining animating views. Let's say we have nested exiting animations:In the current implementation in this case if the animation in
B
ended beforeA
, we would visitA
inmaybeDropAncestors
and decided to removeA
, even though it still has some waiting children. ThenA
would be added to the view recycling pool while still having children. This would cause us to see some zombie views when the view is reused.I changed the
maybeDropAncestors
condition to check the size of thechildren
list. I also removednode->animatedChildren
as I think it is no longer necessary.Fixes #6644
Test plan
Chceck
[LA] View recycling
example, if there are no zombie views in theWheelPicker
component.