Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grantedBy to DataAuthorization #246

Open
justinwb opened this issue Feb 22, 2022 · 2 comments · May be fixed by #304
Open

Add grantedBy to DataAuthorization #246

justinwb opened this issue Feb 22, 2022 · 2 comments · May be fixed by #304

Comments

@justinwb
Copy link
Member

Implementation experience is that this would be useful to have within the DataConsent rather than needing to source it from the AccessConsent.
@elf-pavlik elf-pavlik changed the title Add grantedBy to DataConsent Add grantedBy to DataAuthorization Sep 28, 2022
@elf-pavlik elf-pavlik mentioned this issue Feb 27, 2023
Closed
@elf-pavlik
Copy link
Member

elf-pavlik commented Feb 27, 2023 •
edited
Loading

#299 notes:

@elf-pavlik: I want to double check if it is related to dataOwner since grantedBy is only used for the audit trail.
@justinwb: I haven't come up with a strong reason to have it since I created this issue.

@elf-pavlik
Copy link
Member

Actually comparing the dataOwner and granted for all the scopes except All helps with deciding if DataGrant or DelegatedDataGrant should be generated.

https://github.com/janeirodigital/sai-js/blob/main/packages/data-model/src/readable/data-authorization.ts#L252-L283

@elf-pavlik elf-pavlik reopened this Feb 27, 2023
elf-pavlik added a commit to elf-pavlik/data-interoperability-panel that referenced this issue Feb 27, 2023
@elf-pavlik
added grantedBy to Data Authorization
d3fab86 
closes solid#246
@elf-pavlik elf-pavlik linked a pull request Feb 27, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added grantedBy to Data Authorization elf-pavlik/data-interoperability-panel
2 participants
@justinwb @elf-pavlik