Soft-delete ShippingMethod translations

[kennyadsl]

As we are doing with Product translations, we should also soft-delete shipping method 's translations.

At the moment, we are just keeping them around and they will be restored automatically if the shipping is undiscarded. This works but it's not ideal since they should be marked as discarded as well.

We can improve this extension by just adding the deleted_at column to the spree_shipping_methods_transations table, and adding discard methods to that table as it's currently done with Spree::Product (in its decorator).

Ref: 0293d9f

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[zcallanan]

Looking into implementing this and I've encountered an issue with the setup. I've forked, cloned, and run bundle install per contributing. Running bundle exec rake test_app results an InvalidRepository error. It appears that Octokit is not parsing the repository name from the origin URL.

rake aborted!
Octokit::InvalidRepository: "" is invalid as a repository identifier. Use the user/repo (String) format, or the repository ID (Integer), or a hash containing :repo and :user keys.

Octokit Error.txt

[kennyadsl]

@zcallanan 👋 , please take a look at solidusio/solidus_dev_support#163. It's a long-term fix but in the referenced PRs there's a quick solution that could be applied here as well. Let me know if that works!

[zcallanan]

Following the above I replaced:

s.metadata["source_code_uri"] = 's.homepage if s.homepage'

with:

s.metadata["source_code_uri"] = 'https://github.com/zcallanan/solidus_globalize'

Running bundle exec rake test_app now results in the following error:

rake aborted!
Don't know how to build task 'test_app' (See the list of available tasks with `rake --tasks`)

Running rake --tasks results in the following error. Bundle install provided the 3.0.0 alpha version - Gemfile.lock: solidus_core (= 3.0.0.alpha)

rake aborted!
Gem::MissingSpecError: Could not find 'solidus_core' (>= 2.0, < 3) among 476 total gem(s)
Checked in 'GEM_PATH=/Users/astolot/.gem/ruby/2.6.0:/Users/astolot/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0', execute `gem env` for more information
/Users/astolot/code/zcallanan/solidus_globalize/Rakefile:3:in `<top (required)>'

Caused by:
Gem::MissingSpecError: Could not find 'solidus_core' (>= 2.0, < 3) among 476 total gem(s)
Checked in 'GEM_PATH=/Users/astolot/.gem/ruby/2.6.0:/Users/astolot/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0', execute `gem env` for more information
/Users/astolot/code/zcallanan/solidus_globalize/Rakefile:3:in `<top (required)>'

Caused by:
LoadError: cannot load such file -- solidus_dev_support/rake_tasks
/Users/astolot/code/zcallanan/solidus_globalize/Rakefile:3:in `<top (required)>'

[kennyadsl]

That rake task is recently changed, it's now bundle exec rake extension:test_app. If you can share where did you find that command it would be great so we can update the documentation with the new version. Thanks!

[zcallanan]

It's found on line 71 of the CONTRIBUTING.md in this project.

The test application was created with the new command. One thing of note was I received a number of deprecation warnings (two examples follow):

`DEPRECATION WARNING: SolidusSupport::EngineExtensions::Decorators is deprecated! Use SolidusSupport::EngineExtensions instead. (called from class:Engine at /Users/astolot/code/zcallanan/solidus_globalize/lib/solidus_globalize/engine.rb:9)

DEPRECATION WARNING: SolidusSupport.solidus_gem_version is deprecated and will be removed in solidus_support 1.0. Please use Spree.solidus_gem_version instead. (called from module:Admin at /Users/astolot/code/zcallanan/solidus_globalize/app/decorators/controllers/solidus_globalize/spree/admin/resource_controller_decorator.rb:16)`

As an aside, I noticed what looks like a typo on line 8 of the resource_controller_decorator:

retunr if parent_data.blank?

[zcallanan]

I tried running the command bundle exec rspec spec (line 73 of CONTRIBUTING.md) before making any code changes and received a number of deprecation warnings along with a FactoryBot DuplicateDefinition error:

`Provide a CODECOV_TOKEN environment variable to enable Codecov uploads
Omitted Deprecation Errors

An error occurred while loading spec_helper.
Failure/Error: require 'solidus_dev_support/rspec/feature_helper'

FactoryBot::DuplicateDefinitionError:
Factory already registered: address
#./spec/spec_helper.rb:12:in `<top (required)>'

Run options: include {:focus=>true}`

[kennyadsl]

You can safely ignore the deprecation warnings. Thanks for reporting that typo, can you fix it in a separate PR or even just open a new issue to track it.

[kennyadsl]

An error occurred while loading spec_helper.
Failure/Error: require 'solidus_dev_support/rspec/feature_helper'

This should be fixed now that I've released the last SolidusDevSupport version. Can you please delete the Gemfile.lock and the test app and try again? Sorry for the inconvenience, this should be the last thing.