Remove LSIF functionality, keeping only SCIP support (#1184)

Author: jupblb

CODEOWNERS

@@ -1,4 +1,3 @@
-cmd/src/lsif* @sourcegraph/team-graph
 cmd/src/code_intel* @sourcegraph/team-graph
 
 cmd/src/search* @sourcegraph/search-platform

README.md

@@ -168,7 +168,7 @@ Is your Sourcegraph instance behind a custom auth proxy? See [auth proxy configu
  - `src config` - manage global, org, and user settings
  - `src extsvc` - manage external services (repository configuration)
  - `src extensions` - manage extensions
- - `src code-intel` - manages Code Intelligence data (deprecated alias: `src lsif`)
+ - `src code-intel` - manages Code Intelligence data
  - `src serve-git` - serves your local git repositories over HTTP for Sourcegraph to pull
  - `src version` - check version and guaranteed-compatible version for your Sourcegraph instance
 

cmd/src/BUILD.bazel

@@ -48,7 +48,6 @@ go_library(
         "format.go",
         "headers.go",
         "login.go",
-        "lsif.go",
         "main.go",
         "orgs.go",
         "orgs_create.go",
@@ -132,7 +131,6 @@ go_library(
         "@com_github_sourcegraph_scip//bindings/go/scip",
         "@com_github_sourcegraph_sourcegraph_lib//batches",
         "@com_github_sourcegraph_sourcegraph_lib//batches/template",
-        "@com_github_sourcegraph_sourcegraph_lib//codeintel/lsif/scip",
         "@com_github_sourcegraph_sourcegraph_lib//codeintel/upload",
         "@com_github_sourcegraph_sourcegraph_lib//errors",
         "@com_github_sourcegraph_sourcegraph_lib//output",

cmd/src/code_intel_upload.go

@@ -202,7 +202,7 @@ func makeCodeIntelUploadURL(uploadID int) (string, error) {
 		return "", err
 	}
 
-	graphqlID := base64.URLEncoding.EncodeToString([]byte(fmt.Sprintf(`LSIFUpload:%d`, uploadID)))
+	graphqlID := base64.URLEncoding.EncodeToString([]byte(fmt.Sprintf(`SCIPUpload:%d`, uploadID)))
 	url.Path = codeintelUploadFlags.repo + "/-/code-intelligence/uploads/" + graphqlID
 	url.User = nil
 	return url.String(), nil

cmd/src/code_intel_upload_vendored.go

@@ -501,7 +501,7 @@ func makeUploadURL(opts uploadRequestOptions) (*url.URL, error) {
 
 	path := opts.SourcegraphInstanceOptions.Path
 	if path == "" {
-		path = "/.api/lsif/upload"
+		path = "/.api/scip/upload"
 	}
 
 	parsedUrl, err := url.Parse(opts.SourcegraphInstanceOptions.SourcegraphURL + path)