Avoid setting globals in the CMake setup (#5)

jviotti · web-flow · commit 909ec2bccfdd · 2025-10-09T12:46:24.000-04:00
Signed-off-by: Juan Cruz Viotti &lt;jv@jviotti.com&gt;
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -14,30 +14,12 @@ elseif(MSVC)
   set(HYDRA_COMPILER_MSVC ON)
 endif()
 
-set(CMAKE_CXX_STANDARD 20)
-set(CMAKE_CXX_STANDARD_REQUIRED ON)
-set(CMAKE_CXX_EXTENSIONS OFF)
-set(CMAKE_C_STANDARD 11)
-set(CMAKE_C_STANDARD_REQUIRED ON)
-set(CMAKE_C_EXTENSIONS OFF)
-set(CMAKE_POSITION_INDEPENDENT_CODE ON)
-set(CMAKE_CXX_VISIBILITY_PRESET hidden)
-set(CMAKE_C_VISIBILITY_PRESET hidden)
-set(CMAKE_VISIBILITY_INLINES_HIDDEN ON)
-set(CMAKE_SKIP_BUILD_RPATH FALSE)
-set(CMAKE_BUILD_WITH_INSTALL_RPATH FALSE)
-set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)
-
-if(WIN32)
+if(PROJECT_IS_TOP_LEVEL AND WIN32)
   set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}")
   set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}")
   set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}")
 endif()
 
-if(CMAKE_SYSTEM_NAME STREQUAL "MSYS")
-  add_compile_definitions(_POSIX_C_SOURCE=200809L)
-endif()
-
 find_package(ZLIB REQUIRED)
 
 if(NOT WIN32 OR CMAKE_SYSTEM_NAME STREQUAL "MSYS")
diff --git a/cmake/FindCAres.cmake b/cmake/FindCAres.cmake
@@ -274,6 +274,10 @@ if(NOT CAres_FOUND)
 
   set_target_properties(cares
     PROPERTIES
+      C_STANDARD 11
+      C_STANDARD_REQUIRED ON
+      C_EXTENSIONS OFF
+      POSITION_INDEPENDENT_CODE ON
       OUTPUT_NAME cares
       C_VISIBILITY_PRESET "default"
       C_VISIBILITY_INLINES_HIDDEN FALSE
diff --git a/cmake/FindCPR.cmake b/cmake/FindCPR.cmake
@@ -139,6 +139,10 @@ if(NOT CPR_FOUND)
 
   set_target_properties(cpr
     PROPERTIES
+      CXX_STANDARD 20
+      CXX_STANDARD_REQUIRED ON
+      CXX_EXTENSIONS OFF
+      POSITION_INDEPENDENT_CODE ON
       OUTPUT_NAME cpr
       CXX_VISIBILITY_PRESET "default"
       CXX_VISIBILITY_INLINES_HIDDEN FALSE
diff --git a/cmake/FindCURL.cmake b/cmake/FindCURL.cmake
@@ -456,6 +456,7 @@ if(NOT CURL_FOUND)
     target_compile_definitions(curl PRIVATE CURL_CA_PATH="/usr/ssl/certs")
     target_compile_definitions(curl PRIVATE USE_MBEDTLS)
     target_compile_definitions(curl PRIVATE USE_THREADS_POSIX)
+    target_compile_definitions(curl PRIVATE _POSIX_C_SOURCE=200809L)
     target_compile_definitions(curl PRIVATE HAVE_SYS_TIME_H)
     target_compile_definitions(curl PRIVATE HAVE_LONGLONG)
     target_compile_definitions(curl PRIVATE HAVE_RECV)
@@ -540,6 +541,10 @@ if(NOT CURL_FOUND)
 
   set_target_properties(curl
     PROPERTIES
+      C_STANDARD 11
+      C_STANDARD_REQUIRED ON
+      C_EXTENSIONS OFF
+      POSITION_INDEPENDENT_CODE ON
       OUTPUT_NAME curl
       PUBLIC_HEADER "${CURL_PUBLIC_HEADER}"
       PRIVATE_HEADER "${CURL_PRIVATE_HEADERS}"
diff --git a/cmake/FindMbedTLS.cmake b/cmake/FindMbedTLS.cmake
@@ -169,6 +169,10 @@ if(NOT MbedTLS_FOUND)
 
   set_target_properties(mbedtls
     PROPERTIES
+      C_STANDARD 11
+      C_STANDARD_REQUIRED ON
+      C_EXTENSIONS OFF
+      POSITION_INDEPENDENT_CODE ON
       OUTPUT_NAME mbedtls
       C_VISIBILITY_PRESET "default"
       C_VISIBILITY_INLINES_HIDDEN FALSE
diff --git a/cmake/FindNghttp2.cmake b/cmake/FindNghttp2.cmake
@@ -112,6 +112,10 @@ if(NOT Nghttp2_FOUND)
 
   set_target_properties(nghttp2
     PROPERTIES
+      C_STANDARD 11
+      C_STANDARD_REQUIRED ON
+      C_EXTENSIONS OFF
+      POSITION_INDEPENDENT_CODE ON
       OUTPUT_NAME nghttp2
       C_VISIBILITY_PRESET "default"
       C_VISIBILITY_INLINES_HIDDEN FALSE
diff --git a/cmake/FindPSL.cmake b/cmake/FindPSL.cmake
@@ -76,6 +76,10 @@ if(NOT PSL_FOUND)
 
   set_target_properties(psl
     PROPERTIES
+      C_STANDARD 11
+      C_STANDARD_REQUIRED ON
+      C_EXTENSIONS OFF
+      POSITION_INDEPENDENT_CODE ON
       OUTPUT_NAME psl
       C_VISIBILITY_PRESET "default"
       C_VISIBILITY_INLINES_HIDDEN FALSE
diff --git a/cmake/FindZLIB.cmake b/cmake/FindZLIB.cmake
@@ -86,8 +86,13 @@ if(NOT ZLIB_FOUND)
       OUTPUT_NAME zlib
       PUBLIC_HEADER "${ZLIB_PUBLIC_HEADER}"
       PRIVATE_HEADER "${ZLIB_PRIVATE_HEADERS}"
+      C_STANDARD 11
+      C_STANDARD_REQUIRED ON
+      C_EXTENSIONS OFF
+      POSITION_INDEPENDENT_CODE ON
       C_VISIBILITY_PRESET "default"
       C_VISIBILITY_INLINES_HIDDEN FALSE
+      VISIBILITY_INLINES_HIDDEN OFF
       WINDOWS_EXPORT_ALL_SYMBOLS TRUE
       EXPORT_NAME zlib)
 
diff --git a/test/e2e/CMakeLists.txt b/test/e2e/CMakeLists.txt
@@ -1,19 +1,39 @@
 add_executable(https_request https_request.cc)
 target_link_libraries(https_request PRIVATE CPR::cpr)
+set_target_properties(https_request PROPERTIES
+  CXX_STANDARD 20
+  CXX_STANDARD_REQUIRED ON
+  CXX_EXTENSIONS OFF)
 add_test(NAME hydra.e2e.https_request COMMAND https_request)
 
 add_executable(http2_request http2_request.cc)
 target_link_libraries(http2_request PRIVATE CPR::cpr)
+set_target_properties(http2_request PROPERTIES
+  CXX_STANDARD 20
+  CXX_STANDARD_REQUIRED ON
+  CXX_EXTENSIONS OFF)
 add_test(NAME hydra.e2e.http2_request COMMAND http2_request)
 
 add_executable(compression_test compression_test.cc)
 target_link_libraries(compression_test PRIVATE CPR::cpr)
+set_target_properties(compression_test PROPERTIES
+  CXX_STANDARD 20
+  CXX_STANDARD_REQUIRED ON
+  CXX_EXTENSIONS OFF)
 add_test(NAME hydra.e2e.compression_test COMMAND compression_test)
 
 add_executable(custom_headers_test custom_headers_test.cc)
 target_link_libraries(custom_headers_test PRIVATE CPR::cpr)
+set_target_properties(custom_headers_test PROPERTIES
+  CXX_STANDARD 20
+  CXX_STANDARD_REQUIRED ON
+  CXX_EXTENSIONS OFF)
 add_test(NAME hydra.e2e.custom_headers_test COMMAND custom_headers_test)
 
 add_executable(post_request_test post_json_test.cc)
 target_link_libraries(post_request_test PRIVATE CPR::cpr)
+set_target_properties(post_request_test PROPERTIES
+  CXX_STANDARD 20
+  CXX_STANDARD_REQUIRED ON
+  CXX_EXTENSIONS OFF)
 add_test(NAME hydra.e2e.post_request_test COMMAND post_request_test)
diff --git a/test/packaging/find_package/CMakeLists.txt b/test/packaging/find_package/CMakeLists.txt
@@ -1,13 +1,12 @@
 cmake_minimum_required(VERSION 3.18)
 project(core_hello VERSION 0.0.1 LANGUAGES CXX)
-set(CMAKE_CXX_STANDARD 20)
-set(CMAKE_CXX_STANDARD_REQUIRED ON)
-set(CMAKE_CXX_EXTENSIONS OFF)
 find_package(Hydra REQUIRED)
 add_executable(hello hello.cc)
+set_target_properties(hello PROPERTIES
+  CXX_STANDARD 20
+  CXX_STANDARD_REQUIRED ON
+  CXX_EXTENSIONS OFF)
 
-# We exercise all dependencies to make sure they
-# are all installed and exposed as expected
 target_link_libraries(hello PRIVATE ZLIB::ZLIB)
 if(NOT WIN32 OR CMAKE_SYSTEM_NAME STREQUAL "MSYS")
   target_link_libraries(hello PRIVATE MbedTLS::mbedtls)
