You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The thinking was that computing metrics and plotting results were two separate operations. We've discovered that plotting typically happens deep inside the code wrapped by the class, and we had to store a lot of intermediate data in the vetter, violating the principle of encapsulation.
A better way to do things is to have
def run(self, tce, lc, plot=False):
...
The plot keyword can then be passed into the code executing the logic. We can then get rid of the plot method
The text was updated successfully, but these errors were encountered:
The current design of a vetter is
The thinking was that computing metrics and plotting results were two separate operations. We've discovered that plotting typically happens deep inside the code wrapped by the class, and we had to store a lot of intermediate data in the vetter, violating the principle of encapsulation.
A better way to do things is to have
The plot keyword can then be passed into the code executing the logic. We can then get rid of the
plot
methodThe text was updated successfully, but these errors were encountered: