Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revit connector does not convert copied linked models #3683

Open
5 tasks done
ks-cph opened this issue Jan 29, 2025 · 1 comment
Open
5 tasks done

Revit connector does not convert copied linked models #3683

ks-cph opened this issue Jan 29, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@ks-cph
Copy link
Contributor

ks-cph commented Jan 29, 2025

Prerequisites

What package are you referring to?

Revit converter

Describe the bug

When copying the same linked model several times, Speckle converts them only once. The issue occurs when sending everything by view or selection.

To Reproduce

  1. Open Revit
  2. Link a file
  3. Copy the file several times
  4. Send to Speckle

Expected behavior

We would expect each instance of the copied link to be converted.

System Info

  • Version 21.02
  • Revit 2024

Proposed Solution (if any)

When reading selected elements, you must track their origin, including which version of the linked document they refer to.

Currently, the implementation relies on a unique ID to prevent elements from being converted multiple times. However, the issue is that these copied elements share the same “unique” ID and refer to the same Document. One way to distinguish them is by using the RevitLinkInstance.

We understand that this repository may no longer be your primary focus, but please consider this approach when working on version 3 of the connectors.

@ks-cph ks-cph added the bug Something isn't working label Jan 29, 2025
Copy link

linear bot commented Jan 29, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant