updating details, status display/update logic

Author: klpoland

gateway/sds_gateway/static/js/actions/DetailsActionManager.js

@@ -181,11 +181,9 @@ class DetailsActionManager {
 			".dataset-details-description",
 			datasetData.description || "No description provided",
 		);
-		this.updateElementText(
-			modal,
-			".dataset-details-status",
-			datasetData.status || "Unknown",
-		);
+		// Update status as badge
+		this.updateStatusBadge(modal, datasetData.status);
+
 		this.updateElementText(
 			modal,
 			".dataset-details-created",
@@ -306,6 +304,20 @@ class DetailsActionManager {
 		}
 	}
 
+	/**
+	 * Update status badge
+	 * @param {Element} modal - Modal element
+	 * @param {string} status - Status value ('draft' or 'final')
+	 */
+	updateStatusBadge(modal, status) {
+		const statusContainer = modal.querySelector(".dataset-details-status");
+		const statusText = status[0].toUpperCase() + status.slice(1);
+		const statusClass = status === "final" ? "success" : "secondary";
+		if (statusContainer) {
+			statusContainer.innerHTML = `<span class="badge bg-${statusClass}">${statusText}</span>`;
+		}
+	}
+
 	/**
 	 * Set up UUID copy button functionality
 	 * @param {Element} modal - Modal element

gateway/sds_gateway/static/js/actions/PublishActionManager.js

@@ -17,11 +17,13 @@ class PublishActionManager {
 	 */
 	initializeEventListeners() {
 		// Find all publish modals
-		const publishModals = document.querySelectorAll('[id^="publish-dataset-modal-"]');
+		const publishModals = document.querySelectorAll(
+			'[id^="publish-dataset-modal-"]',
+		);
 
-		publishModals.forEach((modal) => {
+		for (const modal of publishModals) {
 			const datasetUuid = modal.getAttribute("data-dataset-uuid");
-			if (!datasetUuid) return;
+			if (!datasetUuid) continue;
 
 			// Explicitly initialize Bootstrap modal to avoid auto-initialization issues
 			if (window.bootstrap && !bootstrap.Modal.getInstance(modal)) {
@@ -71,7 +73,6 @@ class PublishActionManager {
 						publishToggle,
 						visibilitySection,
 						statusBadge,
-						datasetUuid,
 					);
 				});
 			}
@@ -96,15 +97,21 @@ class PublishActionManager {
 			// Handle publish button click
 			if (publishBtn) {
 				publishBtn.addEventListener("click", () => {
-					this.handlePublish(datasetUuid, publishToggle, privateOption, publicOption);
+					this.handlePublish(
+						datasetUuid,
+						statusBadge,
+						publishToggle,
+						privateOption,
+						publicOption,
+					);
 				});
 			}
-		});
+		}
 
 		// Handle publish button clicks in dropdown (open modal)
-		document.querySelectorAll(".publish-dataset-btn").forEach((btn) => {
+		for (const btn of document.querySelectorAll(".publish-dataset-btn")) {
 			const datasetUuid = btn.getAttribute("data-dataset-uuid");
-			if (!datasetUuid) return;
+			if (!datasetUuid) continue;
 
 			// Only attach handler if modal exists
 			const modalId = `publish-dataset-modal-${datasetUuid}`;
@@ -115,15 +122,15 @@ class PublishActionManager {
 				);
 				btn.disabled = true;
 				btn.classList.add("disabled");
-				return;
+				continue;
 			}
 
 			btn.addEventListener("click", (e) => {
 				e.preventDefault();
 				e.stopPropagation();
 				this.openPublishModal(datasetUuid);
 			});
-		});
+		}
 	}
 
 	/**
@@ -170,7 +177,7 @@ class PublishActionManager {
 	 * @param {HTMLElement} statusBadge - The status badge element
 	 * @param {string} datasetUuid - Dataset UUID
 	 */
-	handlePublishToggleChange(publishToggle, visibilitySection, statusBadge, datasetUuid) {
+	handlePublishToggleChange(publishToggle, visibilitySection, statusBadge) {
 		if (publishToggle.checked) {
 			// Publishing - set status to final and show visibility options
 			if (statusBadge) {
@@ -195,25 +202,32 @@ class PublishActionManager {
 	/**
 	 * Handle publish button click
 	 * @param {string} datasetUuid - Dataset UUID
+	 * @param {HTMLElement} statusBadge - The status badge element
 	 * @param {HTMLElement} publishToggle - The publish toggle checkbox
 	 * @param {HTMLElement} privateOption - The private option radio button
 	 * @param {HTMLElement} publicOption - The public option radio button
 	 */
-	async handlePublish(datasetUuid, publishToggle, privateOption, publicOption) {
+	async handlePublish(
+		datasetUuid,
+		statusBadge,
+		publishToggle,
+		privateOption,
+		publicOption,
+	) {
 		if (!window.APIClient) {
 			console.error("APIClient not available");
 			return;
 		}
 
 		try {
-			// Get current values
-			const status = publishToggle && publishToggle.checked ? "final" : "draft";
-			const isPublic =
-				publicOption && publicOption.checked
-					? "true"
-					: privateOption && privateOption.checked
-						? "false"
-						: "false";
+			const status = publishToggle?.checked
+				? "final"
+				: statusBadge?.textContent?.toLowerCase() || "draft";
+			const isPublic = publicOption?.checked
+				? "true"
+				: privateOption?.checked
+					? "false"
+					: "false";
 
 			// Prepare data
 			const data = {
@@ -243,7 +257,9 @@ class PublishActionManager {
 				);
 
 				// Close modal
-				const modal = document.getElementById(`publish-dataset-modal-${datasetUuid}`);
+				const modal = document.getElementById(
+					`publish-dataset-modal-${datasetUuid}`,
+				);
 				if (modal) {
 					const bsModal = bootstrap.Modal.getInstance(modal);
 					if (bsModal) {
@@ -392,4 +408,4 @@ class PublishActionManager {
 			alert(message);
 		}
 	}
-}
+}

gateway/sds_gateway/static/js/dataset/DatasetEditingHandler.js

@@ -1240,31 +1240,6 @@ class DatasetEditingHandler {
 					window.DOMUtils.hide(addAuthorBtn);
 				}
 			}
-
-			// Disable author inputs if dataset is final
-			if (window.datasetModeManager?.isExistingFinalDataset()) {
-				const authorInputs = authorsList.querySelectorAll(
-					".author-name-input, .author-orcid-input",
-				);
-				for (const input of authorInputs) {
-					input.disabled = true;
-					input.setAttribute("readonly", "readonly");
-					input.classList.add("form-control-plaintext");
-				}
-				// Also disable remove buttons for authors
-				const removeButtons = authorsList.querySelectorAll(
-					".remove-author, .cancel-remove-author",
-				);
-				for (const button of removeButtons) {
-					button.disabled = true;
-					button.classList.add("disabled-element");
-				}
-				// Disable add button if not already disabled
-				if (addAuthorBtn) {
-					addAuthorBtn.disabled = true;
-					addAuthorBtn.classList.add("disabled");
-				}
-			}
 		};
 
 		/**