break publishing step into a partial template

Author: klpoland

gateway/sds_gateway/api_methods/models.py

@@ -1334,11 +1334,6 @@ def user_has_access_to_item(user: "User", item_uuid: uuid.UUID, item_type: str)
     """
     return UserSharePermission.user_can_view(user, item_uuid, item_type)
 
-def get_user_permission_level(user, item_uuid, item_type):
-    """
-    Get the permission level for a user on a specific item.
-    """
-    return UserSharePermission.get_user_permission_level(user, item_uuid, item_type)
 
 def get_user_permission_level(
     user: "User", item_uuid: uuid.UUID, item_type: str

gateway/sds_gateway/static/js/dataset/DatasetEditingHandler.js

@@ -1242,26 +1242,23 @@ class DatasetEditingHandler {
 			}
 
 			// Disable author inputs if dataset is final
-			if (
-				window.datasetModeManager &&
-				window.datasetModeManager.isExistingFinalDataset()
-			) {
+			if (window.datasetModeManager?.isExistingFinalDataset()) {
 				const authorInputs = authorsList.querySelectorAll(
 					".author-name-input, .author-orcid-input",
 				);
-				authorInputs.forEach((input) => {
+				for (const input of authorInputs) {
 					input.disabled = true;
 					input.setAttribute("readonly", "readonly");
 					input.classList.add("form-control-plaintext");
-				});
+				}
 				// Also disable remove buttons for authors
 				const removeButtons = authorsList.querySelectorAll(
 					".remove-author, .cancel-remove-author",
 				);
-				removeButtons.forEach((button) => {
+				for (const button of removeButtons) {
 					button.disabled = true;
 					button.classList.add("disabled-element");
-				});
+				}
 				// Disable add button if not already disabled
 				if (addAuthorBtn) {
 					addAuthorBtn.disabled = true;