Skip to content

Fix for tests #24

Description

@spideydotjs

SpriteFrameRepositoryTest.kt

  • Unresolved reference 'debug' — wrong import, probably importing a debug build config that doesn't exist in test scope
  • Unresolved reference 'SpriteBox'SpriteBox was likely renamed or moved and the test wasn't updated

SettingsTest.kt

  • Type mismatch — test expects ConnectionValidationResult but the production code now returns UrlValidationResult. Someone refactored the type and forgot to update the test.

OllamaViewModelTest.kt

  • FakeModelPreferenceDao doesn't implement getAllBaseUrls — a new method was added to the DAO interface but the fake used in tests wasn't updated
  • FakeBaseUrlProvider doesn't implement replaceAll — same deal, interface changed and the fake is out of sync

All three are the same root cause: production code changed, tests weren't kept in sync. Nothing wrong with CI or Gradle.

Fix order:

  1. Update FakeModelPreferenceDao and FakeBaseUrlProvider to implement the new methods
  2. Fix the ConnectionValidationResultUrlValidationResult mismatch in SettingsTest
  3. Fix the SpriteBox import/reference in SpriteFrameRepositoryTest

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions