renamed visible text from indoor-tour to katalog-tour, added separate method is_indoor to tour

Author: David Schunke

controllers/mapstops_controller.php

@@ -36,7 +36,7 @@ public static function new() {
             $mapstop = new Mapstop();
             $mapstop->tour_id = $tour->id;
 
-            if ($tour->type === 'indoor-tour') {
+            if ($tour->is_indoor()) {
                 $places = Places::instance()->list_by_area($tour->area_id);
             } else {
                 $places = Mapstops::instance()->get_possible_places($mapstop);
@@ -104,7 +104,7 @@ public static function edit() {
         if(is_null($error_view)) {
             $available_posts = UserService::instance()->get_available_posts();
             $posts = UserService::instance()->get_posts($mapstop->post_ids);
-            if ($tour->type === 'indoor-tour') {
+            if ($tour->is_indoor()) {
                 $places = Places::instance()->list_by_area($tour->area_id);
             } else {
                 $places = Mapstops::instance()->get_possible_places($mapstop);

controllers/tours_controller.php

@@ -132,7 +132,7 @@ public static function edit_track() {
         $id = RouteParams::get_id_value();
         $tour = Tours::instance()->get($id, true, true, true);
 
-        if ($tour->type === 'indoor-tour') {
+        if ($tour->is_indoor()) {
             $view = self::determine_edit_view($tour, 'edit_track_indoor');
         } else {
             $view = self::determine_edit_view($tour, 'edit_track');
@@ -149,7 +149,7 @@ public static function edit_stops() {
         $id = RouteParams::get_id_value();
         $tour = Tours::instance()->get($id, true, true, true);
 
-        if ($tour->type === 'indoor-tour') {
+        if ($tour->is_indoor()) {
             $view = self::determine_edit_view($tour, 'edit_stops_indoor');
         } else {
             $view = self::determine_edit_view($tour, 'edit_stops');

models/tour.php

@@ -12,7 +12,7 @@ class Tour extends AbstractModel {
         'round-tour' => 'Rundgang',
         'public-transport-tour' => 'ÖPNV-Tour',
         'bike-tour' => 'Fahrrad-Tour',
-        'indoor-tour' => 'Indoor-Tour'
+        'indoor-tour' => 'Katalog-Tour'
     );
 
     const DATETIME_FORMATS = array(
@@ -318,10 +318,7 @@ private function datetime_from_julian_date($julian_date) {
         return $dt;
     }
 
+    public function is_indoor() {
+        return $this->type === 'indoor-tour';
+    }
 }
-
-
-
-
-
-?>

publishing_check.php

@@ -115,7 +115,7 @@ public static function run($tour) {
             $failures[] = $failure;
         }
 
-        if ($tour->type === 'indoor-tour') {
+        if ($tour->is_indoor()) {
             $messages = self::check_tour_scenes($tour->scenes);
             if (!empty($messages)) {
                 $failure = new PublishingCheckFailure($messages);