Gotcha when using outbound HTTP (bodies with GET requests)

[rylev]

The current implementation just silently drops request bodies attached to GET requests inheriting the behavior of Hyper. I'm not against the fact that we don't support bodies on GET requests, but it can be a pretty big gotcha when most SDKs default to GET requests.

[lann]

To clarify, you think this should result in an error?

[rylev]

I don't know what should happen. Just registering that the current behavior is very confusing. Whether we solve this by erroring or warning or something else, I don't have strong opinions of at this time.

[lann]

GET bodies are a messy topic; they might be forbidden or ignored or "implementation-specific" depending on which version of which spec you look at. The one existing system I know has historically relied on them is Elasticsearch and though they now support POST as an alternative I'm sure there is still code that uses GET. On the other hand there are also e.g. proxies that don't handle it at all, so you're probably looking at a compatibility hazard either way.

I guess the smallest incremental improvement here would be to log a warning, though I'm not even sure how straightforward that is.