Fix Stempler parsing of @ inside a string that is not a directive. (#1197)

Author: spiralbot

src/Lexer/Buffer.php

@@ -20,7 +20,7 @@ final class Buffer implements \IteratorAggregate
     public function __construct(
         /** @internal */
         private readonly \Generator $generator,
-        private int $offset = 0
+        private int $offset = 0,
     ) {
     }
 
@@ -136,4 +136,9 @@ public function replay(int $offset): void
             }
         }
     }
+
+    public function cleanReplay(): void
+    {
+        $this->replay = [];
+    }
 }

src/Lexer/Grammar/Dynamic/DirectiveGrammar.php

@@ -229,6 +229,12 @@ private function finalize(): bool
     {
         $tokens = $this->tokens;
 
+        // A directive must have at least one keyword
+        // Without it, it's just a char
+        if (\count($tokens) === 1 && $tokens[0]->content === self::DIRECTIVE_CHAR) {
+            return false;
+        }
+
         foreach (\array_reverse($tokens, true) as $i => $t) {
             if ($t->type !== DynamicGrammar::TYPE_WHITESPACE) {
                 break;

src/Lexer/Grammar/DynamicGrammar.php

@@ -45,20 +45,20 @@ final class DynamicGrammar implements GrammarInterface
     private readonly BracesGrammar $raw;
 
     public function __construct(
-        private readonly ?DirectiveRendererInterface $directiveRenderer = null
+        private readonly ?DirectiveRendererInterface $directiveRenderer = null,
     ) {
         $this->echo = new BracesGrammar(
             '{{',
             '}}',
             self::TYPE_OPEN_TAG,
-            self::TYPE_CLOSE_TAG
+            self::TYPE_CLOSE_TAG,
         );
 
         $this->raw = new BracesGrammar(
             '{!!',
             '!!}',
             self::TYPE_OPEN_RAW_TAG,
-            self::TYPE_CLOSE_RAW_TAG
+            self::TYPE_CLOSE_RAW_TAG,
         );
     }
 
@@ -107,6 +107,10 @@ public function parse(Buffer $src): \Generator
 
                     $src->replay($directive->getLastOffset());
                     continue;
+                } else {
+                    // When we found directive char but it's not a directive, we need to clean the replay buffer
+                    // because it may contain extra tokens that we don't need to return back to the stream
+                    $src->cleanReplay();
                 }
 
                 $src->replay($n->offset);

tests/Directive/DirectiveTest.php

@@ -2,10 +2,9 @@
 
 declare(strict_types=1);
 
-namespace Directive;
+namespace Spiral\Tests\Stempler\Directive;
 
 use Spiral\Tests\Stempler\fixtures\ImageDirective;
-use Spiral\Tests\Stempler\Directive\BaseTestCase;
 
 final class DirectiveTest extends BaseTestCase
 {

tests/Transform/DynamicToPHPTest.php

@@ -4,8 +4,10 @@
 
 namespace Spiral\Tests\Stempler\Transform;
 
+use PHPUnit\Framework\Attributes\DataProvider;
 use Spiral\Stempler\Directive\LoopDirective;
 use Spiral\Stempler\Node\PHP;
+use Spiral\Stempler\Node\Raw;
 use Spiral\Stempler\Transform\Finalizer\DynamicToPHP;
 
 class DynamicToPHPTest extends BaseTestCase
@@ -17,6 +19,20 @@ public function testOutput(): void
         self::assertInstanceOf(PHP::class, $doc->nodes[0]);
     }
 
+    public static function provideStringWithoutDirective(): iterable
+    {
+        yield ['https://unpkg.com/tailwindcss@^1.6/dist/tailwind.min.css'];
+    }
+
+    #[DataProvider('provideStringWithoutDirective')]
+    public function testLinkWithReservedSymbol(string $string): void
+    {
+        $doc = $this->parse($string);
+
+        self::assertInstanceOf(Raw::class, $doc->nodes[0]);
+        self::assertSame($string, $doc->nodes[0]->content);
+    }
+
     public function testDirective(): void
     {
         $doc = $this->parse('@foreach($users as $u) @endforeach');