Enable Attack Data Download before Test #392
Merged
+215
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errors
attack data cache work easy to use, intuitive, and minimally intrusive for the average content developer
different prefix, ensure that it exists via a head request. If it does not give an exception. otherwise, ensure just print out that it exists but is not in a cache
be replayed. this is not required anymore and is a waste of resources because these files are no longer modified in any way during a test. we used to sometimes modify these with update_timestamps which is no longer supported.
info if those files are available in the cache
the relevant files are missing from the attack_data cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If attack_data repo exists, then
use it instead. otherwise, or
if the file is not found in the
repo, default to a download.
If the file is not found, but we SHOULD have found it, we throw an error at validate time.
This PR supersedes the previous attempt at this implementation:
#374