.

Author: sbylica-splunk

package/sbin/healthcheck.py

@@ -19,14 +19,12 @@ def get_list_of_destinations():
     found_destinations = []
     regex = r"^SC4S_DEST_SPLUNK_HEC_(.*)_URL$"
 
-    for env_var_key, _ in os.environ.items():
-        if re.search(regex, env_var_key):
-            found_destinations.append(env_var_key)
-    print("Found destinations: {}".format(set(found_destinations)))
+    for var_key, var_variable in os.environ.items():
+        if re.search(regex, var_key):
+            found_destinations.append(var_variable)
     return set(found_destinations)
 
 class Config:
-    SC4S_DEST_SPLUNK_HEC_DEFAULT_URL = os.getenv('SC4S_DEST_SPLUNK_HEC_DEFAULT_URL')
     HEALTHCHECK_PORT = int(os.getenv('SC4S_LISTEN_STATUS_PORT', '8080'))
     CHECK_QUEUE_SIZE = str_to_bool(os.getenv('HEALTHCHECK_CHECK_QUEUE_SIZE', "false"))
     MAX_QUEUE_SIZE = int(os.getenv('HEALTHCHECK_MAX_QUEUE_SIZE', '10000'))
@@ -85,8 +83,7 @@ def check_queue_size(
         stats = result.stdout.splitlines()
 
         queue_sizes_all_destinations = []
-        logger.error(f"Destinations {sc4s_dest_splunk_hec_destinations}.")
-        logger.error(f"Stats {stats}.")
+
         for destination in sc4s_dest_splunk_hec_destinations:
             destination_stat = next(
                 (s for s in stats if ";queued;" in s and destination in s),

tests/test_healthcheck_unit_tests.py

@@ -216,5 +216,5 @@ def test_get_destinations():
     destinations = get_list_of_destinations()
 
     assert len(destinations) == 2
-    assert "SC4S_DEST_SPLUNK_HEC_DEFAULT_URL" in destinations
-    assert "SC4S_DEST_SPLUNK_HEC_OTHER_URL" in destinations
+    assert "http://my_test_url:1234" in destinations
+    assert "http://my_hec:1234" in destinations