fix: Fix NAME cache IPv4/IPv6 key collisions and IPv6 SQLite overflow - #3198
Open
digrajpu wants to merge 1 commit into
Open
fix: Fix NAME cache IPv4/IPv6 key collisions and IPv6 SQLite overflow#3198digrajpu wants to merge 1 commit into
digrajpu wants to merge 1 commit into
Conversation
digrajpu
requested review from
Kawron,
ajasnosz and
sbylica-splunk
as code owners
August 20, 2026 12:32
Collaborator
|
@digrajpu please add description to this PR |
Collaborator
|
Code lgtm, but have you tested it manually? I think it will be worth doing to make sure we don't break anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NAME cache was converting SOURCEIP to a plain integer before storing it as a SQLite key. This caused two bugs:
Fix: Replace the integer key with a family-tagged string (v4:192.0.2.2, v6:2001:db8::1) generated by ip_cache_key() using Python's ipaddress module. This guarantees no cross-family collisions and stores safely as a string in SQLite. Existing caches will cold-repopulate under the new key namespace; operators can use SC4S_CLEAR_NAME_CACHE=yes for a one-time cleanup on upgrade.