Skip to content
This repository was archived by the owner on Jan 17, 2019. It is now read-only.

Commit c707533

Browse files
authored
Merge pull request #257 from cerihughes/dont-cast-to-NSUInteger
Use condensed form of unsigned cast.
2 parents 185da1f + 7e3bac5 commit c707533

File tree

6 files changed

+112
-112
lines changed

6 files changed

+112
-112
lines changed

tests/HUBComponentModelBuilderTests.m

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -247,15 +247,15 @@ - (void)testChildPreferredIndexRespected
247247
childBuilderE.componentName = @"component";
248248

249249
id<HUBComponentModel> const model = [self.builder buildForIndex:0 parent:nil];
250-
XCTAssertEqual(model.children.count, (NSUInteger)5);
250+
XCTAssertEqual(model.children.count, 5u);
251251
XCTAssertEqualObjects(model.children[0].identifier, childIdentifierE);
252-
XCTAssertEqual(model.children[0].index, (NSUInteger)0);
252+
XCTAssertEqual(model.children[0].index, 0u);
253253
XCTAssertEqualObjects(model.children[1].identifier, childIdentifierD);
254-
XCTAssertEqual(model.children[1].index, (NSUInteger)1);
254+
XCTAssertEqual(model.children[1].index, 1u);
255255
XCTAssertEqualObjects(model.children[2].identifier, childIdentifierA);
256-
XCTAssertEqual(model.children[2].index, (NSUInteger)2);
256+
XCTAssertEqual(model.children[2].index, 2u);
257257
XCTAssertEqualObjects(model.children[3].identifier, childIdentifierC);
258-
XCTAssertEqual(model.children[3].index, (NSUInteger)3);
258+
XCTAssertEqual(model.children[3].index, 3u);
259259
}
260260

261261
- (void)testChildOutOfBoundsPreferredIndexHandled
@@ -268,9 +268,9 @@ - (void)testChildOutOfBoundsPreferredIndexHandled
268268
childBuilder.preferredIndex = @99;
269269

270270
id<HUBComponentModel> const model = [self.builder buildForIndex:0 parent:nil];
271-
XCTAssertEqual(model.children.count, (NSUInteger)1);
271+
XCTAssertEqual(model.children.count, 1u);
272272
XCTAssertEqualObjects(model.children[0].identifier, childIdentifier);
273-
XCTAssertEqual(model.children[0].index, (NSUInteger)0);
273+
XCTAssertEqual(model.children[0].index, 0u);
274274
}
275275

276276
- (void)testRemovingChildComponentModel
@@ -294,11 +294,11 @@ - (void)testRemovingAllChildComponentModelBuilders
294294
[self.builder builderForChildWithIdentifier:@"child2"].componentName = @"component";
295295
[self.builder builderForChildWithIdentifier:@"child3"].componentName = @"component";
296296

297-
XCTAssertEqual([self.builder buildForIndex:0 parent:nil].children.count, (NSUInteger)3);
297+
XCTAssertEqual([self.builder buildForIndex:0 parent:nil].children.count, 3u);
298298

299299
[self.builder removeAllChildBuilders];
300300

301-
XCTAssertEqual([self.builder buildForIndex:0 parent:nil].children.count, (NSUInteger)0);
301+
XCTAssertEqual([self.builder buildForIndex:0 parent:nil].children.count, 0u);
302302
}
303303

304304
- (void)testChildReferenceToParent
@@ -432,7 +432,7 @@ - (void)testAddingJSONDataAndModelSerialization
432432
XCTAssertEqualObjects(model.icon.identifier, iconIdentifier);
433433
XCTAssertEqualObjects(model.target.URI, targetURL);
434434
XCTAssertEqualObjects(model.target.initialViewModel.navigationItem.title, targetTitle);
435-
XCTAssertEqual(model.target.actionIdentifiers.count, (NSUInteger)1);
435+
XCTAssertEqual(model.target.actionIdentifiers.count, 1u);
436436
XCTAssertEqualObjects(model.target.actionIdentifiers.firstObject, targetActionIdentifier);
437437

438438
XCTAssertEqualObjects(model.metadata, metadata);

tests/HUBViewControllerFactoryTests.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ - (void)testDefaultContentReloadPolicyUsedIfFeatureDidNotSupplyOne
180180
[viewController viewWillAppear:YES];
181181

182182
XCTAssertEqualObjects(self.defaultContentReloadPolicy.lastViewURI, viewURI);
183-
XCTAssertEqual(self.defaultContentReloadPolicy.numberOfRequests, (NSUInteger)1);
183+
XCTAssertEqual(self.defaultContentReloadPolicy.numberOfRequests, 1u);
184184
}
185185

186186
- (void)testDefaultActionHandlerUsedIfFeatureDidNotSupplyOne
@@ -217,7 +217,7 @@ - (void)testDefaultActionHandlerUsedIfFeatureDidNotSupplyOne
217217

218218
[viewController selectComponentWithModel:componentModel customData:customData];
219219

220-
XCTAssertEqual(self.defaultActionHandler.contexts.count, (NSUInteger)1);
220+
XCTAssertEqual(self.defaultActionHandler.contexts.count, 1u);
221221
XCTAssertEqualObjects(self.defaultActionHandler.contexts[0].componentModel, componentModel);
222222
XCTAssertEqualObjects(self.defaultActionHandler.contexts[0].customData, customData);
223223
}

0 commit comments

Comments
 (0)