improvements for reading code and changes to direkt, dark social

Author: Nicole Emer

extensions/doPlugins/doPlugins_global.js

@@ -149,7 +149,10 @@ s._utils = {
             .getEntriesByType('navigation')
             .map((nav) => nav.type).toString();
 
-    }
+    },
+    isPageStatus: function(expectedStatus) {
+        return this.getPageReloadStatus() === expectedStatus;
+    },
 };
 
 /**
@@ -316,12 +319,19 @@ s._articleViewTypeObj = {
 
     isDirect: function (referrer) {
         const noReferrer = this.isWithoutReferrer(referrer);
+        const newVisit = this.isNewVisit();
+        
+        return (noReferrer && newVisit);
+
+    },
+
+    isNewVisit: function () {
         const sessionStart = s._utils.isSessionStart();
         const pageOneInSession = s._utils.isPageOneInSession();
 
-        return (noReferrer && (sessionStart || pageOneInSession));
+        return (sessionStart || pageOneInSession);
 
-    },
+    },    
 
     isValidURL: function (urlString) {
         try {
@@ -340,11 +350,14 @@ s._articleViewTypeObj = {
         }
     },
 
-    isNavigated: function(){
-        const reloadStatus = s._utils.getPageReloadStatus();
-        return window.performance && (window.performance.navigation && window.performance.navigation.type === 0) || reloadStatus === 'navigate';
+    isNavigated: function () {
+        return s._utils.isPageStatus('navigate');
     },
-    
+
+    isReloaded: function () {
+        return s._utils.isPageStatus('reload'); 
+    },
+
     isSelfRedirect: function() {
         return (s._ppvPreviousPage || '').includes((s.pageName || 'NEVER').split(':').pop());
     },
@@ -379,9 +392,8 @@ s._articleViewTypeObj = {
 
     getExternalType: function (referrer) {
         const referringDomain = s._utils.getDomainFromURLString(referrer);
-        const isSessionStart = s._utils.isSessionStart();
+        const isNewVisit = this.isNewVisit();
         const isHomepage = s._utils.isHomepage();
-        const isArticle = s._utils.isArticlePage(); 
         let pageViewEvent;
         let channel;
         let mkt_channel_detail;
@@ -410,27 +422,37 @@ s._articleViewTypeObj = {
             pageViewEvent = 'event205'; 
             channel = 'AS News';
             mkt_channel_detail = referringDomain;
-        } else if ((this.isFromPremiumService(referrer)||this.isFromPaypal(referrer)) && isSessionStart) {
+        } else if ((this.isFromPremiumService(referrer)||this.isFromPaypal(referrer)) && isNewVisit) {
             pageViewEvent = 'event208'; 
             channel = 'Register & Payment';
             mkt_channel_detail = referringDomain;
         } else if (this.isFromPremiumService(referrer)||this.isFromPaypal(referrer)) {
             pageViewEvent = 'event23,event201'; // Login via secure.mypass during session
-        } else if (this.isDirect() && this.isNavigated() && isArticle) {
+        } else {
+            pageViewEvent = 'event27,event203';  // Other External (Referrer)
+            channel = 'Other External';
+            mkt_channel_detail = referringDomain;
+        }
+        return {pageViewEvent, channel, mkt_channel_detail};
+    },
+
+    noReferrerType: function () {
+        const isArticle = s._utils.isArticlePage(); 
+        const isNewVisit = this.isNewVisit();
+        const isNavigated = this.isNavigated();
+        const isReloaded = this.isReloaded();
+        let pageViewEvent;
+        let channel;
+        let mkt_channel_detail;
+
+        if (isNewVisit && isNavigated && isArticle) {
             pageViewEvent = 'event26,event202'; // Dark Social 
             channel = 'Dark Social';
-        } else if (this.isDirect() && this.isNavigated()) {
+        } else if (isNewVisit && (isNavigated || isReloaded)) {
             pageViewEvent = 'event207'; // Direct 
             channel = 'Direct';
-        }else if (this.isWithoutReferrer() && this.isNavigated() && isArticle) {
-            pageViewEvent = 'event26,event202'; // Dark Social Marketing Channel only with session start
-        }else if (this.isDirect(referrer)) {
-            pageViewEvent = 'event207'; // Fallback
-            channel = 'Direct';
-        }  else {
-            pageViewEvent = 'event27,event203';  // Other External (Referrer)
-            channel = 'Other External';
-            mkt_channel_detail = referringDomain;
+        } else if (isNavigated || isReloaded) {
+            pageViewEvent = 'event23,event201'; 
         }
         return {pageViewEvent, channel, mkt_channel_detail};
     },
@@ -441,7 +463,14 @@ s._articleViewTypeObj = {
         let channel;
         let mkt_channel_detail;
 
-        if (this.isFromInternal(referrer)) {
+        if (!referrer) {
+            // no Referrer is set
+            const noReferrerType = this.noReferrerType(referrer);
+            pageViewEvent = noReferrerType.pageViewEvent;
+            channel = noReferrerType.channel;
+            mkt_channel_detail = '';
+
+        } else if (this.isFromInternal(referrer)) {
             // Referrer is of same domain
             const internalType = this.getInternalType(referrer);
             pageViewEvent = internalType.pageViewEvent;
@@ -470,9 +499,13 @@ s._articleViewTypeObj = {
         const isFromReco = this.isFromReco();
         const pageNumberOne = s._utils.isPageOneInSession();
         const isFromRecoFf = this.isFromRecoFf();
+        const pageIsReloaded = this.isReloaded();
+        const newVisit = this.isNewVisit();
 
-
-        if (trackingValue.startsWith('sea.')) {
+        if (trackingValue && pageIsReloaded && newVisit) {
+            pageViewEvent = 'event207'; // Direct 
+            channel = 'Direct';
+        } else if (trackingValue.startsWith('sea.')) {
             pageViewEvent = 'event24,event206,event242'; // Search
             channel = 'Paid Marketing';
             channelCategory = 'Sea';
@@ -572,7 +605,8 @@ s._articleViewTypeObj = {
 
     setExtraViewTypes: function(s) {
         const trackingChannel= this.isOtherTrackingValue();
-        if (trackingChannel) {
+        const pageIsReloaded = this.isReloaded();
+        if (trackingChannel && !pageIsReloaded) {
             s._setTrackingValueEvents(s);
         } else {
             s._setExternalReferringDomainEvents(s);