Skip to content

Extract magic number to named constant in conversion tracking delay #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: TIPPI-896_cmp_list_align
Choose a base branch
from
Draft

Extract magic number to named constant in conversion tracking delay #326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62ef195
Initial plan
Copilot Dec 1, 2025
c626449
refactor: Extract 150ms delay to CONVERSION_DATA_WAIT_MS constant
Copilot Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion extensions/kilkaya/k5a_meta_send.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
/* global a, b */
/* eslint-disable-next-line no-unused-vars */
(function (a, b) {
// Configuration: delay to ensure conversion data is set by conversion extension
var CONVERSION_DATA_WAIT_MS = 150;

try {
if (String(b.event_name) !== 'checkout' || String(b.event_action) !== 'success') {
return;
Expand Down Expand Up @@ -80,7 +83,7 @@
} catch (err) {
persistLog('✗ ERROR sending conversion', {error: err.message, stack: err.stack});
}
}, 150); // Small delay to ensure k5aMeta.conversion is set
}, CONVERSION_DATA_WAIT_MS);

} catch (e) {
try {
Expand Down