Skip to content

Commit 32f22a6

Browse files
artembilanspring-builds
authored andcommitted
GH-3418: Warn on ack failure in the AbstractAdaptableMessageListener
Fixes: #3418 The message could be ack'ed in the error handler without any evidence and clue for the `AbstractAdaptableMessageListener` to determine what to do with afterward. * Use `logger.warn()` instead of `error` in the `AbstractAdaptableMessageListener.basicAck()` when `channel.basicAck()` fails for the provided message, which, essentially, might be already acke'ed this or other way in the user's error handler (cherry picked from commit b7f773a)
1 parent 7c239fb commit 32f22a6

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/adapter/AbstractAdaptableMessageListener.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ protected void basicAck(Message request, @Nullable Channel channel) {
453453
channel.basicAck(request.getMessageProperties().getDeliveryTag(), false);
454454
}
455455
catch (IOException e) {
456-
this.logger.error("Failed to ack message", e);
456+
this.logger.warn("Failed to ack message", e);
457457
}
458458
}
459459
}

0 commit comments

Comments
 (0)