Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EndpointRequest.toLinks() does not match when management.endpoints.web.base-path is '/' #35595

Closed
wants to merge 2 commits into from

Conversation

somayaj
Copy link
Contributor

@somayaj somayaj commented May 22, 2023

Fix for bug fix #34834. The code now allows for no cleanup of the "/" path to "".
The rest of the test cases stay as is.
Added new tests to verify behaviour

@philwebb philwebb changed the title Fix for https://github.com/spring-projects/spring-boot/issues/34834 EndpointRequest.toLinks() does not match when management.endpoints.web.base-path is '/' May 22, 2023
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 22, 2023
@somayaj
Copy link
Contributor Author

somayaj commented May 24, 2023

Hi @philwebb @wilkinsona @mbhave any eta on when the pr will be looked at?

@wilkinsona
Copy link
Member

@somayaj No ETA I'm afraid. We'll review it as soon as we have time to do so. Thanks for your patience in the meantime.

@somayaj
Copy link
Contributor Author

somayaj commented May 26, 2023

Thanks so much

@wilkinsona
Copy link
Member

Thanks for the PR, @somayaj. Unfortunately, I don't think we should have accepted your offer of a contribution to fix this one as it's deceptively complicated. The matching behavior needs to differ depending on whether or not a separate management port is in use as the use of a different port affects whether or not the links endpoint is available. If we merged these changes and a separate management port was not being used, permitting access to the links endpoint could accidentally permit access to something else. Sorry for the wasted effort here.

@wilkinsona wilkinsona closed this Jun 7, 2023
@somayaj
Copy link
Contributor Author

somayaj commented Jun 11, 2023

Thanks for the PR, @somayaj. Unfortunately, I don't think we should have accepted your offer of a contribution to fix this one as it's deceptively complicated. The matching behavior needs to differ depending on whether or not a separate management port is in use as the use of a different port affects whether or not the links endpoint is available. If we merged these changes and a separate management port was not being used, permitting access to the links endpoint could accidentally permit access to something else. Sorry for the wasted effort here.

@wilkinsona sure, sounds good. Thanks for the opportunity.

@wilkinsona wilkinsona removed the status: waiting-for-triage An issue we've not yet triaged label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EndpointRequest.toLinks() does not match when management.endpoints.web.base-path is '/'
3 participants