Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation lists coordinates for some dependencies that are not actually managed #44855

Closed
askoog opened this issue Mar 24, 2025 · 3 comments
Assignees
Labels
type: documentation A documentation update
Milestone

Comments

@askoog
Copy link

askoog commented Mar 24, 2025

The documentation on managed dependencies specifies that errorprone is managed as:

com.google.errorprone error_prone_annotations 2.18.0

But there is no such specified value in spring-boot-dependencies bom

Should it be managed or is the documentation wrong? Since the documentation seems to be generated, are there more bom:s used than the spring-boot-dependencies bom?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 24, 2025
@wilkinsona
Copy link
Member

spring-boot-dependencies imports several other boms so you should not expect to see every dependency in the docs listed in the source for spring-boot-dependencies. That said, error_prone_annotations should probably not be managed. #42522 is covering tidying up some unwanted dependency management and this appears to be another instance of that.

@wilkinsona
Copy link
Member

On closer investigation, I think it's the documentation that's incorrect. com.google.errorprone:error_prone_annotations doesn't appear in the effective pom of spring-boot-dependencies so it should not be listed in the documentation. This may be similar to #43584.

@wilkinsona wilkinsona reopened this Mar 24, 2025
@wilkinsona
Copy link
Member

com.google.j2objc:j2objc-annotations:2.8 is also listed in the managed coordinates but is not actually managed.

@snicoll snicoll added status: waiting-for-triage An issue we've not yet triaged and removed status: duplicate A duplicate of another issue labels Mar 24, 2025
@philwebb philwebb added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 24, 2025
@philwebb philwebb added this to the 3.3.x milestone Mar 24, 2025
@philwebb philwebb assigned wilkinsona and unassigned wilkinsona Mar 24, 2025
@philwebb philwebb added status: waiting-for-triage An issue we've not yet triaged and removed type: documentation A documentation update labels Mar 24, 2025
@philwebb philwebb removed this from the 3.3.x milestone Mar 24, 2025
@wilkinsona wilkinsona self-assigned this Mar 24, 2025
@wilkinsona wilkinsona changed the title Errorprone annotations is dependency managed according to documentation but not present in spring-boot-dependencies Documentation lists coordinates for some dependencies that are not actually managed Mar 25, 2025
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 25, 2025
@wilkinsona wilkinsona added this to the 3.3.x milestone Mar 25, 2025
@wilkinsona wilkinsona modified the milestones: 3.3.x, 3.3.11 Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

5 participants