Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When converting Micrometer data to Otlp, the max value in Timer will be lost in the default configuration. #44872

Closed
songmiao-hhh opened this issue Mar 25, 2025 · 3 comments
Labels
for: external-project For an external project and not something we can fix status: duplicate A duplicate of another issue

Comments

@songmiao-hhh
Copy link

I have Redis latency statistics recorded by Lettuce in Spring Boot, and latency statistics are Micrometer data. When I try to send the latency statistics to my otlp collector , I found that the max data in the Micrometer Timer was lost after the latency statistics were converted to Otlp data.
My configuration is as follows:
otel.resource.attributes=service.name=otlpTest management.otlp.metrics.export.url=http://localhost:8000/v1/metrics management.otlp.metrics.export.aggregationTemporality="delta" management.metrics.distribution.percentiles-histogram.lettuce.command.completion=true
Spring Boot version : 3.4.3

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 25, 2025
@wilkinsona
Copy link
Member

Exporting Micrometer's meters in OTLP format is handled by Micrometer's OtlpMeterRegistry and Spring Boot isn't really involved. As such, I think it's likely that this is a Micrometer issue rather than a Spring Boot issue. To help us or the Micrometer team determine the cause, please provide a complete yet minimal sample that reproduces the problem. You can share it with us by pushing it to a separate repository on GitHub or by zipping it up and attaching it to this issue.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Mar 25, 2025
@BenEfrati
Copy link

The only way is to register a gauge for max.
Check this change in OtlpMetricConverter
BenEfrati/micrometer@1796553
BenEfrati/micrometer@bdb0cb6

micrometer-metrics/micrometer#3144 (comment)

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Mar 26, 2025
@wilkinsona wilkinsona added status: duplicate A duplicate of another issue for: external-project For an external project and not something we can fix and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Mar 26, 2025
@wilkinsona
Copy link
Member

Thanks very much, @BenEfrati. I'll close this one in favor of the existing Micrometer issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: external-project For an external project and not something we can fix status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

4 participants