Null key returned for cache operation

[wangsp188]

@Cacheable(key="@cpwTcrCampaignKey.getAccountIdTcrCampaignIdPrefix()")
public Integer hello2(String key,boolean xx){
    return Integer.parseInt(key);
}

if this @cpwTcrCampaignKey.getAccountIdTcrCampaignIdPrefix() return null
then throw error.
java.lang.IllegalArgumentException: Null key returned for cache operation (maybe you are using named params on classes without debug info?) Builder[public java.lang.Integer test.ground.springcache.SpringCacheService.hello2(java.lang.String,boolean)] caches=[h1] | key='@cpwTcrCampaignKey.getAccountIdTcrCampaignIdPrefix()' | keyGenerator='' | cacheManager='' | cacheResolver='' | condition='' | unless='' | sync='false'

Can we not handle the cache when return is null not throw error to main thread?

[mp911de]

Spring's Cache abstraction requires a non-null key for its operations. Once you've called the cache method, then you're inside the cache call and your declarations must adhere to the non-null key contract.

[wangsp188]

@mp911de But we can't predict whether the method's entry is reasonable or not. , we would expect to return null after the function's internal judgment when encountering such an invalid parameter, but now we are directly reporting an error on aspect

[mp911de]

Then you have to guard the method entry by calling the key generator function up front.

[wangsp188]

@mp911de do you means is this?

public Integer hello(){
    String key = cpwTcrCampaignKey.getAccountIdTcrCampaignIdPrefix();
    if (key == null) {
        return null;
    }
    return this.hello2(null, false);
}

But we found that this is very low.
For aspect cache enhancements, we believe they should be business-neutral，
Now where the cache is called, we need to manually sense how the cache is built before we can call the cache api

[mp911de]

If you feel this handling should be extended then feel free to submit an enhancement proposal to https://github.com/spring-projects/spring-framework/issues as Spring Framework maintains cache aspects. Spring Data Redis only provides a cache backend implementation.

[wangsp188]

@mp911de thanks