Skip to content

Make RegisteredClient.Builder methods @Nullable for @Nullable properties #19597

Description

@OrangeDog

Expected Behavior

RegisteredClient.Builder has various @Nullable properties - id, clientId, clientSecret, etc. and can be initialised from an existing RegisteredClient. The fluent setters for these properties should also have @Nullable parameters.

Current Behavior

Passing null to these methods has no ill-effect, but analysis tools flag it as an error.

Context

When constructing a client from input data you want to be able to use the fluent interface, and not add null checks around every method to avoid calling it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions