Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run gofmt/goimports even if goreturn cannot build the package #30

Open
zimmski opened this issue Jan 2, 2017 · 1 comment
Open

Run gofmt/goimports even if goreturn cannot build the package #30

zimmski opened this issue Jan 2, 2017 · 1 comment

Comments

@zimmski
Copy link

zimmski commented Jan 2, 2017

  1. Put the following into "$GOPATH/src/sourcegraph.com/sqs/goreturns/hey/ho.go"
// +build something

package main

func foo() { }
  1. Execute goreturns -d $GOPATH/src/sourcegraph.com/sqs/goreturns/hey/ho.go

The execution will print the problem "no buildable Go source files in ...".

I am not saying that goreturns should automatically interpret the build tags and then build the package with the correct tags, but it would be nice if it could run gofmt/goimports anyway.

@sqs
Copy link
Owner

sqs commented Jan 2, 2017

Thanks. Good call. I'd happily accept a PR that implements this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants