Merge pull request #66 from square/stromberg/gardening/test-infra

Delete the deprecated test APIs/helper types

Author: AquaGeek

MigrationGuide_v1.0.md

@@ -15,6 +15,21 @@
 `Workflow.rendered(with:key:)` was deprecated in Workflow v1.0α and has been removed in the beta. See details in the alpha migration guide, [below](#render-child-workflow).
 `RenderContext.render(workflow:key:outputMap:)` has been made `internal` instead of `public`. Child `Workflow`s should be rendered via `ChildWorkflow().rendered(in: context)` instead.
 
+### Testing APIs
+
+All of the deprecated APIs covered in [Testing](#testing) below have been removed in the beta:
+* `RenderTester.render(file:expectedState:expectedOutput:expectedWorkers:expectedWorkflows:expectedSideEffects:assertions:)`
+* `RenderTester.render(file:line:with:assertions:)`
+* `RenderTester.assert(state:)`
+* `RenderExpectations`
+* `ExpectedOutput`
+* `ExpectedWorker`
+* `ExpectedState`
+* `ExpectedSideEffect`
+* `ExpectedWorkflow`
+* `WorkflowActionTester.send(action:outputAssertions:)`
+* `WorkflowActionTester.assertState(_:)`
+
 ---
 
 # Workflow v1.0α Migration Guide

WorkflowReactiveSwift/Testing/WorkerTesting+Deprecated.swift

@@ -55,25 +55,6 @@ class WorkerTests: XCTestCase {
         disposable?.dispose()
     }
 
-    @available(*, deprecated) // Marked to silence deprecation warnings
-    func testExpectedWorkerDeprecatedTests() {
-        SignalProducerTestWorkflow(key: "")
-            .renderTester()
-            .render(
-                expectedState: ExpectedState(state: 1),
-                expectedWorkflows: [
-                    ExpectedWorkflow(
-                        type: WorkerWorkflow<SignalProducerTestWorker>.self,
-                        key: "",
-                        rendering: (),
-                        output: 1,
-                        assertions: { _ in }
-                    ),
-                ],
-                assertions: { _ in }
-            )
-    }
-
     // A worker declared on a first `render` pass that is not on a subsequent should have the work cancelled.
     func test_cancelsWorkers() {
         struct WorkerWorkflow: Workflow {

WorkflowReactiveSwift/Tests/WorkerTests.swift

@@ -161,23 +161,3 @@ extension WorkflowActionTester where WorkflowType.Output: Equatable {
         }
     }
 }
-
-extension WorkflowActionTester {
-    private func legacyVerifyOutputShim(_ assertions: (WorkflowType.Output?) -> Void) -> WorkflowActionTester<WorkflowType, Action> {
-        assertions(output)
-        return self
-    }
-
-    @available(*, deprecated, message: "use `send(action:)` followed by `verifyOutput(_:)`, `verify(output:)` or `assertNoOutput()`")
-    @discardableResult
-    public func send(action: Action, outputAssertions: (WorkflowType.Output?) -> Void = { _ in }) -> WorkflowActionTester<WorkflowType, Action> {
-        return send(action: action)
-            .legacyVerifyOutputShim(outputAssertions)
-    }
-
-    @available(*, deprecated, renamed: "verifyState")
-    @discardableResult
-    public func assertState(_ assertions: (WorkflowType.State) -> Void) -> WorkflowActionTester<WorkflowType, Action> {
-        return verifyState(assertions)
-    }
-}