Fixer now uses temporary system files for diffing rather than creating them in the current working dir

Author: gsherwood

CodeSniffer/Fixer.php

@@ -223,18 +223,31 @@ public function generateDiff($filePath=null)
             $filePath = $this->_currentFile->getFilename();
         }
 
-        $cwd       = getcwd().DIRECTORY_SEPARATOR;
-        $filename  = str_replace($cwd, '', $filePath);
-        $fixedFile = $cwd.'phpcs-fixed.tmp';
-        $contents  = $this->getContents();
+        $cwd      = getcwd().DIRECTORY_SEPARATOR;
+        $filename = str_replace($cwd, '', $filePath);
+        $contents = $this->getContents();
+
+        if (function_exists('sys_get_temp_dir') === true) {
+            // This is needed for HHVM support, but only available from 5.2.1.
+            $tempName  = tempnam(sys_get_temp_dir(), 'phpcs-fixer');
+            $fixedFile = fopen($tempName, 'w');
+        } else {
+            $fixedFile = tmpfile();
+            $data      = stream_get_meta_data($fixedFile);
+            $tempName  = $data['uri'];
+        }
 
-        file_put_contents($fixedFile, $contents);
+        fwrite($fixedFile, $contents);
 
         // We must use something like shell_exec() because whitespace at the end
         // of lines is critical to diff files.
-        $cmd  = "diff -u -L\"$filename\" -LPHP_CodeSniffer \"$filename\" \"$fixedFile\"";
+        $cmd  = "diff -u -L\"$filename\" -LPHP_CodeSniffer \"$filename\" \"$tempName\"";
         $diff = shell_exec($cmd);
-        unlink($fixedFile);
+
+        fclose($fixedFile);
+        if (is_file($tempName) === true) {
+            unlink($tempName);
+        }
 
         return $diff;
 

package.xml

@@ -27,6 +27,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
  <license uri="https://github.com/squizlabs/PHP_CodeSniffer/blob/master/licence.txt">BSD 3-Clause License</license>
  <notes>
   - Improved default output for PHPCBF and removed the options to print verbose and progress output
+  - Fixer now uses temporary system files for diffing rather than creating them in the current working dir
   - If a .fixed file is supplied for a unit test file, the auto fixes will be checked against it during testing
     -- See Generic ScopeIndentUnitTest.inc and ScopeIndentUnitTest.inc.fixed for an example
   - Fixer token replacement methods now return TRUE if the change was accepted and FALSE if rejected