refactor(h3): remove 0-RTT early data and server push dead code

st0o0 · st0o0 · commit 24d1b9e134ed · 2026-05-05T19:18:04.000+02:00
diff --git a/src/Servus.Akka.Tests/Transport/Quic/Client/QuicTransportStateMachineSpec.cs b/src/Servus.Akka.Tests/Transport/Quic/Client/QuicTransportStateMachineSpec.cs
@@ -140,21 +140,6 @@ public void Dispatch_OutboundWriteDone_should_signal_pull()
         Assert.True(ops.PullCount > 0);
     }
 
-    [Fact(Timeout = 5000)]
-    public void Dispatch_EarlyDataRejected_should_push_DataRejected()
-    {
-        var ops = new StubOps();
-        var sm = new QuicTransportStateMachine(ops, ActorRefs.Nobody, ActorRefs.Nobody);
-
-        var buffer = TransportBuffer.Rent(16);
-        buffer.Length = 4;
-
-        sm.Dispatch(new EarlyDataRejected(buffer));
-
-        Assert.Single(ops.PushedInbound);
-        Assert.IsType<DataRejected>(ops.PushedInbound[0]);
-    }
-
     [Fact(Timeout = 5000)]
     public void HandlePush_DisconnectTransport_should_signal_pull()
     {
diff --git a/src/Servus.Akka.Tests/Transport/Quic/QuicTransportEventSpec.cs b/src/Servus.Akka.Tests/Transport/Quic/QuicTransportEventSpec.cs
@@ -140,19 +140,4 @@ public void MigrationDetected_should_implement_IQuicTransportEvent()
         Assert.Same(newEndPoint, evt.NewEndPoint);
     }
 
-    [Fact(Timeout = 5000)]
-    public void EarlyDataRejected_should_implement_IQuicTransportEvent()
-    {
-        var buffer = TransportBuffer.Rent(32);
-        try
-        {
-            var evt = new EarlyDataRejected(buffer);
-
-            Assert.NotNull(evt.Buffer);
-        }
-        finally
-        {
-            buffer.Dispose();
-        }
-    }
 }
diff --git a/src/Servus.Akka.Tests/Transport/TransportOptionsSpec.cs b/src/Servus.Akka.Tests/Transport/TransportOptionsSpec.cs
@@ -114,7 +114,6 @@ public void QuicTransportOptions_should_have_correct_defaults()
         Assert.Equal(TimeSpan.FromSeconds(30), opts.IdleTimeout);
         Assert.Equal(100, opts.MaxBidirectionalStreams);
         Assert.Equal(3, opts.MaxUnidirectionalStreams);
-        Assert.False(opts.AllowEarlyData);
         Assert.True(opts.AllowConnectionMigration);
     }
 
diff --git a/src/Servus.Akka/Transport/ITransportInbound.cs b/src/Servus.Akka/Transport/ITransportInbound.cs
@@ -18,8 +18,6 @@ public sealed record ServerStreamAccepted(long StreamId, StreamDirection Directi
 
 public sealed record InboundStreamAccepted(long StreamId, long StreamType) : ITransportInbound;
 
-public sealed record DataRejected(TransportBuffer Buffer) : ITransportInbound;
-
 public sealed record ConnectionMigrationDetected(
     System.Net.EndPoint OldEndPoint,
     System.Net.EndPoint NewEndPoint) : ITransportInbound;
diff --git a/src/Servus.Akka/Transport/Quic/Client/QuicTransportStateMachine.cs b/src/Servus.Akka/Transport/Quic/Client/QuicTransportStateMachine.cs
@@ -90,9 +90,6 @@ internal void Dispatch(IQuicTransportEvent evt)
             case MigrationDetected e:
                 _ops.OnPushInbound(new ConnectionMigrationDetected(e.OldEndPoint, e.NewEndPoint));
                 break;
-            case EarlyDataRejected e:
-                _ops.OnPushInbound(new DataRejected(e.Buffer));
-                break;
         }
     }
 
diff --git a/src/Servus.Akka/Transport/Quic/QuicTransportEvent.cs b/src/Servus.Akka/Transport/Quic/QuicTransportEvent.cs
@@ -25,4 +25,4 @@ internal interface IQuicTransportEvent;
 
 internal readonly record struct MigrationDetected(EndPoint OldEndPoint, EndPoint NewEndPoint) : IQuicTransportEvent;
 
-internal readonly record struct EarlyDataRejected(TransportBuffer Buffer) : IQuicTransportEvent;
+
diff --git a/src/Servus.Akka/Transport/QuicTransportOptions.cs b/src/Servus.Akka/Transport/QuicTransportOptions.cs
@@ -10,7 +10,6 @@ public sealed record QuicTransportOptions : TransportOptions
     public TimeSpan IdleTimeout { get; init; } = TimeSpan.FromSeconds(30);
     public int MaxBidirectionalStreams { get; init; } = 100;
     public int MaxUnidirectionalStreams { get; init; } = 3;
-    public bool AllowEarlyData { get; init; }
     public bool AllowConnectionMigration { get; init; } = true;
     public X509CertificateCollection? ClientCertificates { get; init; }
     public RemoteCertificateValidationCallback? ServerCertificateValidationCallback { get; init; }
diff --git a/src/TurboHTTP.Tests/Http3/Connection/Http3EarlyDataSpec.cs b/src/TurboHTTP.Tests/Http3/Connection/Http3EarlyDataSpec.cs
diff --git a/src/TurboHTTP.Tests/Http3/Connection/Http3StateMachineEdgeCasesSpec.cs b/src/TurboHTTP.Tests/Http3/Connection/Http3StateMachineEdgeCasesSpec.cs
@@ -47,31 +47,14 @@ public void TryBuildControlPreface_should_return_null_on_subsequent_calls()
 
     [Fact(Timeout = 5000)]
     [Trait("RFC", "RFC9114-6.2")]
-    public void TryBuildControlPreface_should_include_max_push_id_when_push_enabled()
+    public void TryBuildControlPreface_should_not_include_max_push_id()
     {
-        var sm = CreateMachine(new TurboClientOptions { Http3 = new Http3Options { AllowServerPush = true } });
-
-        var preface = sm.TryBuildControlPreface();
-
-        Assert.NotNull(preface);
-        var buf = (MultiplexedData)preface;
-        // Preface contains: StreamType VarInt + Settings frame + MaxPushIdFrame
-        // With MAX_PUSH_ID, size should be larger than without it
-
-        Assert.True(buf.Buffer.Length > 0);
-    }
-
-    [Fact(Timeout = 5000)]
-    [Trait("RFC", "RFC9114-6.2")]
-    public void TryBuildControlPreface_should_not_include_max_push_id_when_push_disabled()
-    {
-        var sm = CreateMachine(new TurboClientOptions { Http3 = new Http3Options { AllowServerPush = false } });
+        var sm = CreateMachine();
 
         var preface = sm.TryBuildControlPreface();
 
         Assert.NotNull(preface);
         var buf = (MultiplexedData)preface;
-        // Without MaxPushIdFrame, still contains StreamType VarInt + Settings frame
         Assert.Equal(-2, buf.StreamId);
         Assert.True(buf.Buffer.Length > 0);
     }
diff --git a/src/TurboHTTP.Tests/Http3/Connection/Http3StateMachineSpec.cs b/src/TurboHTTP.Tests/Http3/Connection/Http3StateMachineSpec.cs
@@ -115,60 +115,28 @@ public void ProcessFrame_should_warn_on_non_divisible_by_four_goaway()
     }
 
     [Fact(Timeout = 5000)]
-    public void ProcessFrame_should_reject_push_promise_when_push_disabled()
+    public void ProcessFrame_should_reject_push_promise_with_cancel_push()
     {
-        var sm = CreateMachine(new TurboClientOptions { Http3 = new Http3Options { AllowServerPush = false } });
+        var sm = CreateMachine();
         var push = new Http3PushPromiseFrame(1, new byte[] { 0x01 });
 
         var result = sm.ProcessFrame(push);
 
         Assert.Null(result);
-        Assert.Single(_ops.Outbound); // serialized CANCEL_PUSH frame
+        Assert.Single(_ops.Outbound);
         Assert.IsType<TransportData>(_ops.Outbound[0]);
     }
 
     [Fact(Timeout = 5000)]
     public void ProcessFrame_should_warn_when_push_rejected()
     {
-        var sm = CreateMachine(new TurboClientOptions { Http3 = new Http3Options { AllowServerPush = false } });
+        var sm = CreateMachine();
 
         sm.ProcessFrame(new Http3PushPromiseFrame(42, new byte[] { 0x01 }));
 
         Assert.Contains(_ops.Warnings, w => w.Contains("push promise rejected") && w.Contains("42"));
     }
 
-    [Fact(Timeout = 5000)]
-    public void ProcessFrame_should_forward_push_promise_to_app_when_push_enabled()
-    {
-        var sm = CreateMachine(new TurboClientOptions { Http3 = new Http3Options { AllowServerPush = true } });
-        var push = new Http3PushPromiseFrame(1, new byte[] { 0x01 });
-
-        var result = sm.ProcessFrame(push);
-
-        Assert.Same(push, result); // forwarded to app layer
-        Assert.Empty(_ops.Outbound); // no CANCEL_PUSH sent
-    }
-
-    [Fact(Timeout = 5000)]
-    public void ProcessFrame_should_enforce_push_limit_when_push_enabled()
-    {
-        var sm = CreateMachine(new TurboClientOptions { Http3 = new Http3Options { AllowServerPush = true } });
-
-        // The default maxPushCount is 100 when AllowServerPush = true.
-        // Push 100 times to hit the limit, then one more should warn.
-        for (var i = 0; i < 100; i++)
-        {
-            var forwarded = sm.ProcessFrame(new Http3PushPromiseFrame(i, new byte[] { 0x01 }));
-            Assert.NotNull(forwarded); // each push is forwarded to app
-        }
-
-        _ops.Warnings.Clear();
-        var exceeded = sm.ProcessFrame(new Http3PushPromiseFrame(100, new byte[] { 0x01 }));
-
-        Assert.Null(exceeded); // push limit exceeded — not forwarded
-        Assert.Contains(_ops.Warnings, w => w.Contains("Push limit exceeded"));
-    }
-
     [Fact(Timeout = 5000)]
     public void ProcessFrame_should_absorb_cancel_push_frame()
     {
diff --git a/src/TurboHTTP.Tests/OptionsFactorySpec.cs b/src/TurboHTTP.Tests/OptionsFactorySpec.cs
@@ -273,20 +273,6 @@ public void OptionsFactory_should_set_target_host_for_tls_options()
         Assert.Equal("example.com", options.TargetHost);
     }
 
-    [Fact(Timeout = 5000)]
-    public void OptionsFactory_should_preserve_http3_early_data_setting()
-    {
-        var endpoint = CreateHttp3Endpoint();
-        var clientOptions = new TurboClientOptions
-        {
-            Http3 = new Http3Options { AllowEarlyData = true }
-        };
-
-        var options = (QuicTransportOptions)OptionsFactory.Build(endpoint, clientOptions);
-
-        Assert.True(options.AllowEarlyData);
-    }
-
     [Fact(Timeout = 5000)]
     public void OptionsFactory_should_preserve_http3_connection_migration_setting()
     {
diff --git a/src/TurboHTTP/Http3Options.cs b/src/TurboHTTP/Http3Options.cs
@@ -55,15 +55,6 @@ public sealed class Http3Options
     /// </summary>
     public int MaxReconnectAttempts { get; set; } = 3;
 
-    /// <summary>
-    /// Whether to allow QUIC 0-RTT early data for idempotent requests (GET, HEAD, OPTIONS, TRACE, DELETE).
-    /// When enabled, repeat connections to known servers can send the first request before the TLS
-    /// handshake completes, reducing latency. Non-idempotent requests are never sent as early data.
-    /// If the server rejects 0-RTT, the request is automatically re-sent after full handshake.
-    /// Default is false. RFC 9114 §A.1.
-    /// </summary>
-    public bool AllowEarlyData { get; set; }
-
     /// <summary>
     /// Whether to allow QUIC connection migration when the client's local IP address or port changes
     /// (e.g., switching from Wi-Fi to cellular). When enabled, the QUIC connection continues
@@ -73,14 +64,6 @@ public sealed class Http3Options
     /// </summary>
     public bool AllowConnectionMigration { get; set; } = true;
 
-    /// <summary>
-    /// Whether to allow the server to push resources via PUSH_PROMISE frames (RFC 9114 §7.2.5).
-    /// When enabled, the client advertises a MAX_PUSH_ID and accepts server push promises.
-    /// When disabled, received PUSH_PROMISE frames are rejected with CANCEL_PUSH.
-    /// Default is false.
-    /// </summary>
-    public bool AllowServerPush { get; set; }
-
     /// <summary>
     /// Whether to automatically discover HTTP/3 availability via Alt-Svc headers (RFC 7838)
     /// in HTTP/1.1 and HTTP/2 responses. When enabled, Alt-Svc directives advertising "h3"
diff --git a/src/TurboHTTP/Internal/OptionsFactory.cs b/src/TurboHTTP/Internal/OptionsFactory.cs
@@ -37,7 +37,6 @@ internal static TransportOptions Build(RequestEndpoint endpoint, TurboClientOpti
                 SocketSendBufferSize = clientOptions.SocketSendBufferSize,
                 SocketReceiveBufferSize = clientOptions.SocketReceiveBufferSize,
                 AllowConnectionMigration = clientOptions.Http3.AllowConnectionMigration,
-                AllowEarlyData = clientOptions.Http3.AllowEarlyData,
                 IdleTimeout = clientOptions.Http3.IdleTimeout,
                 ApplicationProtocols = alpn,
                 AutoReconnect = true,
diff --git a/src/TurboHTTP/Protocol/Http3/Http3Frame.cs b/src/TurboHTTP/Protocol/Http3/Http3Frame.cs
@@ -122,16 +122,6 @@ internal sealed class Http3HeadersFrame : Http3Frame, IDisposable
     public override FrameType Type => FrameType.Headers;
     public ReadOnlyMemory<byte> HeaderBlock { get; }
 
-    /// <summary>
-    /// When true, indicates this request may be sent as QUIC 0-RTT early data.
-    /// Only set for idempotent HTTP methods (GET, HEAD, OPTIONS, TRACE, DELETE)
-    /// when <see cref="Http3Options.AllowEarlyData"/> is enabled.
-    /// The transport layer uses this flag to decide whether to send the request
-    /// before the TLS handshake completes. RFC 9114 §A.1.
-    /// </summary>
-    // TODO: Not yet wired to transport layer — requires QUIC 0-RTT stream coordination
-    public bool EarlyData { get; set; }
-
     public Http3HeadersFrame(ReadOnlyMemory<byte> headerBlock)
     {
         HeaderBlock = headerBlock;
diff --git a/src/TurboHTTP/Protocol/Http3/StateMachine.cs b/src/TurboHTTP/Protocol/Http3/StateMachine.cs

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,6 @@ public void QuicTransportOptions_should_have_correct_defaults()`
`114`	`114`	`Assert.Equal(TimeSpan.FromSeconds(30), opts.IdleTimeout);`
`115`	`115`	`Assert.Equal(100, opts.MaxBidirectionalStreams);`
`116`	`116`	`Assert.Equal(3, opts.MaxUnidirectionalStreams);`
`117`		`- Assert.False(opts.AllowEarlyData);`
`118`	`117`	`Assert.True(opts.AllowConnectionMigration);`
`119`	`118`	`}`
`120`	`119`
Original file line number	Diff line number	Diff line change
`@@ -90,9 +90,6 @@ internal void Dispatch(IQuicTransportEvent evt)`
`90`	`90`	`case MigrationDetected e:`
`91`	`91`	`_ops.OnPushInbound(new ConnectionMigrationDetected(e.OldEndPoint, e.NewEndPoint));`
`92`	`92`	`break;`
`93`		`- case EarlyDataRejected e:`
`94`		`- _ops.OnPushInbound(new DataRejected(e.Buffer));`
`95`		`- break;`
`96`	`93`	`}`
`97`	`94`	`}`
`98`	`95`
Original file line number	Diff line number	Diff line change
`@@ -25,4 +25,4 @@ internal interface IQuicTransportEvent;`
`25`	`25`
`26`	`26`	`internal readonly record struct MigrationDetected(EndPoint OldEndPoint, EndPoint NewEndPoint) : IQuicTransportEvent;`
`27`	`27`
`28`		`-internal readonly record struct EarlyDataRejected(TransportBuffer Buffer) : IQuicTransportEvent;`
	`28`	`+`