Complete the move of cmd/thv-registry-api outside of toolhive (#2244)

* Complete the move of cmd/thv-registry-api outside of toolhive

Signed-off-by: Radoslav Dimitrov <[email protected]>

* Bump operator Helm chart version to 0.2.24

Signed-off-by: Radoslav Dimitrov <[email protected]>

* Restore registry-api RBAC templates and fix local dev workflow

Signed-off-by: Radoslav Dimitrov <[email protected]>

---------

Signed-off-by: Radoslav Dimitrov <[email protected]>

Author: rdimitrov

Taskfile.yml

@@ -4,9 +4,6 @@ includes:
   operator:
     taskfile: ./cmd/thv-operator/Taskfile.yml
     flatten: true
-  registry-api:
-    taskfile: ./cmd/thv-registry-api/Taskfile.yml
-    flatten: true
 
 tasks:
   docs:
@@ -15,7 +12,7 @@ tasks:
     cmds:
       - rm -rf docs/cli/*
       - go run cmd/help/main.go --dir docs/cli
-      - swag init -g pkg/api/server.go --v3.1 -o docs/server --exclude ./cmd/thv-registry-api
+      - swag init -g pkg/api/server.go --v3.1 -o docs/server
 
   swagger-install:
     desc: Install the swag tool for OpenAPI/Swagger generation

cmd/help/verify.sh

@@ -9,7 +9,7 @@ diff -Naur -I "^  date:" "$tmpdir" docs/cli/
 # Generate API docs in temp directory that mimics the final structure
 api_tmpdir=$(mktemp -d)
 mkdir -p "$api_tmpdir/server"
-swag init -g pkg/api/server.go --v3.1 -o "$api_tmpdir/server" --exclude ./cmd/thv-registry-api
+swag init -g pkg/api/server.go --v3.1 -o "$api_tmpdir/server"
 # Exclude README.md from diff as it's manually maintained
 diff -Naur --exclude="README.md" "$api_tmpdir/server" docs/server/
 

cmd/thv-operator/Taskfile.yml

@@ -125,24 +125,24 @@ tasks:
   operator-deploy-local:
     desc: |
       Build the ToolHive runtime and Operator image locally and deploy it to the K8s cluster.
-      Set ENABLE_EXPERIMENTAL_FEATURES=true to enable experimental features in the operator
-      and automatically build and deploy the registry API image.
+      Set ENABLE_EXPERIMENTAL_FEATURES=true to enable experimental features in the operator.
+      Registry API image is pulled from ghcr.io/stacklok/thv-registry-api:latest
       Example: task operator-deploy-local ENABLE_EXPERIMENTAL_FEATURES=true
     platforms: [linux, darwin]
     vars:
       ENABLE_EXPERIMENTAL_FEATURES: '{{.ENABLE_EXPERIMENTAL_FEATURES | default "false"}}'
+      REGISTRY_API_IMAGE: '{{.REGISTRY_API_IMAGE | default "ghcr.io/stacklok/thv-registry-api:latest"}}'
       OPERATOR_IMAGE:
         sh: KO_DOCKER_REPO=kind.local ko build --local -B ./cmd/thv-operator | tail -n 1
       TOOLHIVE_IMAGE:
         sh: KO_DOCKER_REPO=kind.local ko build --local -B ./cmd/thv-proxyrunner | tail -n 1
-      REGISTRY_API_IMAGE:
-        sh: KO_DOCKER_REPO=kind.local ko build --local -B ./cmd/thv-registry-api | tail -n 1
     cmds:
       - echo "Loading toolhive operator image {{.OPERATOR_IMAGE}} into kind..."
       - kind load docker-image --name toolhive {{.OPERATOR_IMAGE}}
       - echo "Loading toolhive image {{.TOOLHIVE_IMAGE}} into kind..."
       - kind load docker-image --name toolhive {{.TOOLHIVE_IMAGE}}
-      - echo "Loading registry API image {{.REGISTRY_API_IMAGE}} into kind..."
+      - echo "Pulling and loading registry API image {{.REGISTRY_API_IMAGE}} into kind..."
+      - docker pull {{.REGISTRY_API_IMAGE}}
       - kind load docker-image --name toolhive {{.REGISTRY_API_IMAGE}}
       - |
         helm upgrade --install toolhive-operator deploy/charts/operator \

cmd/thv-operator/pkg/registryapi/deployment.go

@@ -249,7 +249,7 @@ func getRegistryAPIImageWithEnvGetter(envGetter func(string) string) string {
 	if img := envGetter("TOOLHIVE_REGISTRY_API_IMAGE"); img != "" {
 		return img
 	}
-	return "ghcr.io/stacklok/toolhive/thv-registry-api:latest"
+	return "ghcr.io/stacklok/thv-registry-api:latest"
 }
 
 // findContainerByName finds a container by name in a slice of containers

cmd/thv-operator/pkg/registryapi/deployment_test.go

@@ -208,14 +208,14 @@ func TestGetRegistryAPIImage(t *testing.T) {
 		{
 			name:        "default image when env not set",
 			setEnv:      false,
-			expected:    "ghcr.io/stacklok/toolhive/thv-registry-api:latest",
+			expected:    "ghcr.io/stacklok/thv-registry-api:latest",
 			description: "Should return default image when environment variable is not set",
 		},
 		{
 			name:        "default image when env empty",
 			envValue:    "",
 			setEnv:      true,
-			expected:    "ghcr.io/stacklok/toolhive/thv-registry-api:latest",
+			expected:    "ghcr.io/stacklok/thv-registry-api:latest",
 			description: "Should return default image when environment variable is empty",
 		},
 		{