Merge pull request #3330 from stan-dev/fix/tuple_to_laplace_options-forwarding

Fix typo in tuple_to_laplace_options forwarding function

Author: WardBrian

stan/math/mix/functor/laplace_marginal_density_estimator.hpp

@@ -154,7 +154,7 @@ inline constexpr auto tuple_to_laplace_options(Options&& ops) {
     }
     auto defaults = laplace_options_default{};
     return laplace_options_user_supplied{
-        value_of(std::get<0>(std::forward<Ops>(ops))),
+        value_of(std::get<0>(std::forward<Options>(ops))),
         std::get<1>(ops),
         std::get<2>(ops),
         defaults.hessian_block_size,
@@ -163,7 +163,7 @@ inline constexpr auto tuple_to_laplace_options(Options&& ops) {
         (std::get<5>(ops) > 0) ? true : false,
     };
   } else {
-    return std::forward<Ops>(ops);
+    return std::forward<Options>(ops);
   }
 }
 

test/unit/math/laplace/tuple_to_laplace_options_test.cpp

@@ -0,0 +1,36 @@
+#include <test/unit/math/test_ad.hpp>
+#include <test/unit/math/laplace/laplace_utility.hpp>
+
+TEST(laplace_utils, tuple_to_laplace_options) {
+  using stan::math::laplace_options_user_supplied;
+  using stan::math::internal::tuple_to_laplace_options;
+
+  auto ops = std::make_tuple(Eigen::VectorXd::Zero(3), 1e-6, 100, 1, 2, 0);
+  auto laplace_opts = tuple_to_laplace_options(ops);
+  EXPECT_EQ(laplace_opts.hessian_block_size, 1);
+  EXPECT_EQ(laplace_opts.solver, 1);
+  EXPECT_EQ(laplace_opts.tolerance, 1e-6);
+  EXPECT_EQ(laplace_opts.max_num_steps, 100);
+  EXPECT_EQ(laplace_opts.line_search.max_iterations, 2);
+  EXPECT_EQ(laplace_opts.allow_fallthrough, false);
+  EXPECT_EQ(laplace_opts.theta_0, Eigen::VectorXd::Zero(3));
+  static_assert(
+      std::is_same_v<decltype(laplace_opts), laplace_options_user_supplied>);
+}
+
+TEST(laplace_utils, tuple_to_laplace_options_move) {
+  using stan::math::laplace_options_user_supplied;
+  using stan::math::internal::tuple_to_laplace_options;
+
+  auto ops = std::make_tuple(Eigen::VectorXd::Zero(3), 1e-6, 100, 1, 2, 1);
+  auto laplace_opts = tuple_to_laplace_options(std::move(ops));
+  EXPECT_EQ(laplace_opts.hessian_block_size, 1);
+  EXPECT_EQ(laplace_opts.solver, 1);
+  EXPECT_EQ(laplace_opts.tolerance, 1e-6);
+  EXPECT_EQ(laplace_opts.max_num_steps, 100);
+  EXPECT_EQ(laplace_opts.line_search.max_iterations, 2);
+  EXPECT_EQ(laplace_opts.allow_fallthrough, true);
+  EXPECT_EQ(laplace_opts.theta_0, Eigen::VectorXd::Zero(3));
+  static_assert(
+      std::is_same_v<decltype(laplace_opts), laplace_options_user_supplied>);
+}