Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include snazzy in package #174

Open
zaynv opened this issue Feb 17, 2018 · 5 comments
Open

Include snazzy in package #174

zaynv opened this issue Feb 17, 2018 · 5 comments

Comments

@zaynv
Copy link

zaynv commented Feb 17, 2018

hi there, I saw the great talk by feross on using standard-engine to wrap our eslint configs. i see that snazzy is a separate tool used to make the output look nice. Is there a way to include the snazzy output with our custom CLI created from standard-engine, or would it be necessary to make some code changes? it would be nice to not have to install two packages everytime you want to lint.

And thanks for this cool package

@rjhilgefort
Copy link

Would love to be able to do this as well. I don't see an obvious way to do it as the current standardEngine.cli(...) returns undefined. If someone points me in the right direction, I'd be happy to poke a bit more.

@theoludwig
Copy link
Member

Indeed, it would be a cool feature to have!
As discussed in : standard/ts-standard#102, standard/standard#1356

I would love to open a PR to implement that, but I have no idea what to do in the code. Could we have more insight of what's going on when we do standard | snazzy for example ? Maybe @feross could help us to implement that.
We could have a new cli option : --report=pretty.

@feross
Copy link
Member

feross commented Feb 23, 2021

I will consider this for the next major version of standard

@feross
Copy link
Member

feross commented Feb 23, 2021

I think if we were to do this, we'd want to consider exposing the built in --format option in ESLint standard/standard#1286 This name would conflict with the prettier --format option, so we need to think about how to handle that.

@theoludwig
Copy link
Member

Maybe we could do like ts-standard does, indeed exposing the --format eslint option but instead the option would be --report still in standard-engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

4 participants