Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all auto-fixable problems not working #450

Open
TechNomad615 opened this issue Aug 11, 2022 · 5 comments
Open

Fix all auto-fixable problems not working #450

TechNomad615 opened this issue Aug 11, 2022 · 5 comments

Comments

@TechNomad615
Copy link

TechNomad615 commented Aug 11, 2022

What version of this package are you using?
v2.1.0

What operating system, Node.js, and npm version?
I am getting the same errors on both Arch Linux and Windows
Arch Linux
NodeJS: 18.7.0
NPM: 8.17.0

Windows 10
NodeJS:17.17.3
NPM:8.12.2

What happened?
Press CTRL + SHIFT + P, select JavaScript Standar Style: Fix all auto-fixable Problems and an error pops up. 'undefined is not validating any files yet Source StandardJS - JavaScript Standard Style (Extension)

What did you expect to happen?
The extension to format the document

Are you willing to submit a pull request to fix this bug?
Never done that before, but I am willing to learn

I also reverted back to the vscode-standardjs (old version) by Sam Chen using ext install chenxsan.vscode-standardjs. This package works as intended on both systems (Linux and Windows). This only started happening after I migrated to the new supported version

@TechNomad615
Copy link
Author

since there has been no updates on this issue I have switched to eslint which works as expected. so I am closing this issue

@Robsonsjre
Copy link

Same issue..newer version of standardJS not working as intended

@kolyasya
Copy link

I can't get the VSCode extension as well, same issue

@maxwellsmart84
Copy link

// "editor.codeActionsOnSave": {
// "source.fixAll": "explicit",
// },

"standard.autoFixOnSave": true,

This fixed autosaving for me with standard - you have to disable vsCode's config

@itaiperi
Copy link

Hey @maxwellsmart84, maybe you can help me, because I'm getting the same error as the author.
This is my settings.json file:

{
  "liveshare.presence": true,
  "explorer.confirmDelete": false,
  "editor.accessibilitySupport": "off",
  "go.autocompleteUnimportedPackages": true,
  "terminal.integrated.fontSize": 16,
  "security.workspace.trust.untrustedFiles": "open",
  "go.useLanguageServer": true,
  "editor.rulers": [
    80
  ],
  "editor.fontFamily": "'Jetbrains Mono', 'Droid Sans Mono', 'monospace', monospace, 'Droid Sans Fallback'",
  "terminal.integrated.env.osx": {
    "FIG_NEW_SESSION": "1",
    "CW_NEW_SESSION": "1",
    "Q_NEW_SESSION": "1"
  },
  "vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
  "editor.fontSize": 16,
  "[yaml]": {
    "editor.tabSize": 2,
    "gitlens.codeLens.scopes": [
      "document"
    ],
    "editor.autoIndent": "advanced",
    "editor.insertSpaces": true
  },
  "terminal.integrated.fontFamily": "MesloLGS NF",
  "markdown.extension.list.indentationSize": "inherit",
  "explorer.confirmDragAndDrop": false,
  "workbench.iconTheme": "eq-material-theme-icons",
  "python.analysis.typeCheckingMode": "basic",
  "python.jediEnabled": false,
  "workbench.editorAssociations": {
    "*.ipynb": "jupyter.notebook.ipynb"
  },
  "editor.fontLigatures": true,
  "git.confirmSync": false,
  "debug.javascript.autoAttachFilter": "smart",
  "editor.suggestSelection": "first",
  "files.autoSave": "onFocusChange",
  "python.languageServer": "Pylance",
  "editor.inlineSuggest.enabled": true,
  "github.copilot.enable": {
    "*": true,
    "yaml": true,
    "plaintext": false,
    "markdown": false
  },
  "files.exclude": {
    "**/__pycache__": true,
    "venv": true
  },
  "terminal.integrated.enableMultiLinePasteWarning": false,
  "editor.formatOnPaste": true,
  "editor.formatOnSave": true,
  "githubPullRequests.createOnPublishBranch": "never",
  "githubPullRequests.queries": [
    {
      "label": "Waiting For My Review",
      "query": "is:open review-requested:${user}"
    },
    {
      "label": "Assigned To Me",
      "query": "is:open assignee:${user}"
    },
    {
      "label": "Assigned to me (with Closed)",
      "query": "author:${user}"
    },
    {
      "label": "Created By Me",
      "query": "is:open author:${user}"
    },
  ],
  "githubPullRequests.fileListLayout": "tree",
  "githubPullRequests.pushBranch": "always",
  "window.zoomLevel": 1,
  "opa.path": "/Users/itaiperi/opa",
  "githubPullRequests.pullBranch": "never",
  "files.insertFinalNewline": true,
  "files.trimFinalNewlines": true,
  "editor.find.autoFindInSelection": "multiline",
  "[python]": {
    "editor.formatOnType": true
  },
  "python.pylanceLspNotebooksEnabled": false,
  "notebook.lineNumbers": "on",
  "typescript.format.insertSpaceAfterOpeningAndBeforeClosingEmptyBraces": false,
  "editor.tabSize": 2,
  // "editor.codeActionsOnSave": {
  //   "source.fixAll.eslint": "explicit"
  // },
  // "eslint.validate": [
  //   "javascript",
  //   "typescript"
  // ],
  "terminal.integrated.gpuAcceleration": "off",
  "typescript.updateImportsOnFileMove.enabled": "always",
  "diffEditor.experimental.showMoves": true,
  "javascript.updateImportsOnFileMove.enabled": "always",
  "jupyter.askForKernelRestart": false,
  "workbench.startupEditor": "none",
  "prisma.showPrismaDataPlatformNotification": false,
  "github.copilot.editor.enableAutoCompletions": true,
  "typescript.preferences.includePackageJsonAutoImports": "on",
  "standard.engine": "ts-standard",
  "standard.autoFixOnSave": true,
  "standard.validate": [
    "javascript",
    "javascriptreact",
    "typescript",
    "typescriptreact"
  ],
  "javascript.format.insertSpaceBeforeFunctionParenthesis": true
}

Any clue to why the auto fixing doesn't work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

5 participants