fix: Nim constants clean-up

Author: alexjba

src/app_service/service/keycard/constants.nim

@@ -109,4 +109,7 @@ const ResponseParamWhisperKey* = RequestParamWhisperKey
 const ResponseParamMnemonicIdxs* = RequestParamMnemonicIdxs
 const ResponseParamTXSignature* = RequestParamTXSignature
 const ResponseParamExportedKey* = RequestParamExportedKey
-const ResponseParamMasterKeyAddress* = RequestParamMasterKeyAddress
+const ResponseParamMasterKeyAddress* = RequestParamMasterKeyAddress
+
+const SignalKeycardStatusChanged* = "status-changed"
+const SignalKeycardChannelStateChanged* = "channel-state-changed"

src/app_service/service/keycard/service.nim

@@ -125,7 +125,7 @@ QtObject:
       return
 
     let flowType = typeObj.getStr
-    if flowType == "channel-state-changed":
+    if flowType == SignalKeycardChannelStateChanged:
         return #nothing related to flows here
 
     let flowEvent = toKeycardEvent(eventObj)

src/app_service/service/keycardV2/service.nim

@@ -9,6 +9,7 @@ import ./dto, rpc
 featureGuard KEYCARD_ENABLED:
   import keycard_go
   import constants as status_const
+  import ../keycard/constants as keycard_constants
 
 export dto
 
@@ -115,10 +116,10 @@ QtObject:
       var jsonSignal = signal.parseJson
       let signalType = jsonSignal["type"].getStr
 
-      if signalType == "status-changed":
+      if signalType == keycard_constants.SignalKeycardStatusChanged:
         let keycardEvent = jsonSignal["event"].toKeycardEventDto()
         self.events.emit(SIGNAL_KEYCARD_STATE_UPDATED, KeycardEventArg(keycardEvent: keycardEvent))
-      elif signalType == "channel-state-changed":
+      elif signalType == keycard_constants.SignalKeycardChannelStateChanged:
         let state = jsonSignal["event"]["state"].getStr
         debug "keycardV2 service: emitting channel state update", state=state, signal=SIGNAL_KEYCARD_CHANNEL_STATE_UPDATED
         self.events.emit(SIGNAL_KEYCARD_CHANNEL_STATE_UPDATED, KeycardChannelStateArg(state: state))