Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"eq() not a number: <0.01" Error shown after transaction confirmation #21251

Closed
VolodLytvynenko opened this issue Sep 11, 2024 · 4 comments · Fixed by #21282 or #21306
Closed

"eq() not a number: <0.01" Error shown after transaction confirmation #21251

VolodLytvynenko opened this issue Sep 11, 2024 · 4 comments · Fixed by #21282 or #21306
Assignees
@seanstrom
Labels
high-prio wallet-core Issues for mobile wallet team
Milestone
2.31.0

Comments

@VolodLytvynenko
Copy link
Contributor

Follow up for #21235

Steps:

  1. Open account
  2. Go to the routes generation page -> confirm a transaction

Actual result:

The user is redirected to the activity page, where the error message "eq() not a number: <0.01" is displayed.

image

Expected result:

The transaction should be confirmed without showing any error messages

OS:

IOS, Android

Devices:

  • Pixel 7a, Android 13
  • iPhone 11 Pro Max, IOS 17

Logs

logs (7).zip
@VolodLytvynenko VolodLytvynenko added high-prio bug wallet-core Issues for mobile wallet team labels Sep 11, 2024
@VolodLytvynenko VolodLytvynenko added this to the 2.31.0 Beta milestone Sep 11, 2024
@vkjr vkjr self-assigned this Sep 18, 2024
@shivekkhurana
Copy link
Contributor

@vkjr It is possible that this issue gets by itself after #21281 is merged. (Status Desktop pr 5807 might fix it).

Please confirm that before working on a fix.

@shivekkhurana shivekkhurana mentioned this issue Sep 19, 2024
Merged
@VolodLytvynenko VolodLytvynenko mentioned this issue Sep 19, 2024
Closed
@vkjr
Copy link
Contributor

vkjr commented Sep 19, 2024

@shivekkhurana, the exception will disappear but I'd like to investigate how the string that causes exception makes it way to .eq function because it shouldn't

@vkjr vkjr assigned seanstrom and unassigned vkjr Sep 20, 2024
@smohamedjavid smohamedjavid mentioned this issue Sep 23, 2024
Merged
@smohamedjavid
Copy link
Member

The routes generation needs to stop after the transaction is successfully made. The existing RPC createMultiTransaction doesn't stop the routes generation after the transaction is created. That's why these errors are thrown, because it was processing the route signals after the transaction is confirmed/created.

I see @seanstrom has created a PR to handle the BigNumber crash and added RPC to stop route calculation on the routes generation page. That will stop route calculation after a token transaction is made. But, collectible transactions will still have this issue. I have fixed it in the PR: #21306

@seanstrom
Copy link
Member

@smohamedjavid Nice catch! 🙌
Thanks for fixing this 🙏

@ilmotta ilmotta removed the bug label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanstrom seanstrom

Labels
high-prio wallet-core Issues for mobile wallet team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.31.0
6 participants
@ilmotta @shivekkhurana @seanstrom @vkjr @smohamedjavid @VolodLytvynenko