Auto-generated commit

Author: stdlib-bot

.github/workflows/test_coverage.yml

@@ -72,5 +72,5 @@ jobs:
         env:
           webhook_url: ${{ secrets.STDLIB_COVERAGE_URL }}
           webhook_secret: ${{ secrets.STDLIB_WEBHOOK_SECRET }}
-          data: '{ "coverage": ${{ steps.extract-coverage.outputs.coverage }}, "run_id": "${{ github.run_id }}" }'
+          data: '${{ steps.extract-coverage.outputs.coverage }}'
         if: ${{ false }}

lib/main.js

@@ -26,9 +26,9 @@ var isCollection = require( '@stdlib/assert-is-collection' );
 var isArrayBuffer = require( '@stdlib/assert-is-arraybuffer' );
 var isObject = require( '@stdlib/assert-is-object' );
 var isFunction = require( '@stdlib/assert-is-function' );
-var hasOwnProp = require( '@stdlib/assert-has-own-property' );
 var ctors = require( '@stdlib/array-ctors' );
 var gfill = require( '@stdlib/blas-ext-base-gfill' );
+var filled = require( '@stdlib/array-base-filled' );
 var hasIteratorSymbolSupport = require( '@stdlib/assert-has-iterator-symbol-support' );
 var ITERATOR_SYMBOL = require( '@stdlib/symbol-iterator' );
 
@@ -40,26 +40,6 @@ var HAS_ITERATOR_SYMBOL = hasIteratorSymbolSupport();
 
 // FUNCTIONS //
 
-/**
-* Creates a filled "generic" array.
-*
-* @private
-* @param {NonNegativeInteger} len - array length
-* @param {*} value - fill value
-* @returns {Array} filled array
-*/
-function filled( len, value ) {
-	var arr;
-	var i;
-
-	// Manually push elements in order to ensure "fast" elements...
-	arr = [];
-	for ( i = 0; i < len; i++ ) {
-		arr.push( value );
-	}
-	return arr;
-}
-
 /**
 * Creates a filled "generic" array from an iterator.
 *
@@ -75,12 +55,10 @@ function filledIterator( it, value ) {
 	arr = [];
 	while ( true ) {
 		v = it.next();
-		if ( hasOwnProp( v, 'value' ) ) {
-			arr.push( value );
-		}
 		if ( v.done ) {
 			break;
 		}
+		arr.push( value );
 	}
 	return arr;
 }
@@ -211,7 +189,7 @@ function filledarray() {
 				len = arg.length;
 			}
 			if ( len !== void 0 ) {
-				return filled( len, value );
+				return filled( value, len );
 			}
 			if ( isArrayBuffer( arg ) ) {
 				throw new Error( 'invalid arguments. Creating a generic array from an ArrayBuffer is not supported.' );
@@ -238,16 +216,16 @@ function filledarray() {
 	if ( nargs <= 0 ) {
 		return new ctor( 0 );
 	}
+	// TODO: there are possible performance improvements here. Namely, for array-like object and iterator source values, we need only know the length; otherwise, we traverse an output array twice, setting values along the way both times.
 	if ( nargs === 1 ) {
 		arr = new ctor( arguments[1] );
 	} else if ( nargs === 2 ) {
 		arr = new ctor( arguments[1], arguments[2] );
 	} else {
 		arr = new ctor( arguments[1], arguments[2], arguments[3] );
 	}
-	value = arguments[ 0 ];
-	if ( arr.length > 0 && value !== 0 ) { // we only need to fill a typed array if the fill value isn't zero, as typed arrays are always zero-initialized
-		gfill( arr.length, value, arr, 1 );
+	if ( arr.length > 0 ) {
+		gfill( arr.length, arguments[ 0 ], arr, 1 );
 	}
 	return arr;
 }

package.json

@@ -37,9 +37,9 @@
     "url": "https://github.com/stdlib-js/stdlib/issues"
   },
   "dependencies": {
+    "@stdlib/array-base-filled": "^0.0.x",
     "@stdlib/array-ctors": "^0.0.x",
     "@stdlib/assert-has-iterator-symbol-support": "^0.0.x",
-    "@stdlib/assert-has-own-property": "^0.0.x",
     "@stdlib/assert-is-arraybuffer": "^0.0.x",
     "@stdlib/assert-is-collection": "^0.0.x",
     "@stdlib/assert-is-function": "^0.0.x",