Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor random number generation in stats/base/dists/rayleigh #5104

Merged
merged 3 commits into from
Feb 8, 2025
Merged

chore: refactor random number generation in stats/base/dists/rayleigh #5104

merged 3 commits into from
Feb 8, 2025

Conversation

ekambains
Copy link
Contributor

…ps and used uniform instead of randu

Resolves #4985

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for stats/base/dists/rayleigh.
  • Replaces randu() with uniform() for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #{{TODO: add issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@ekambains
rayleigh: moved random number generation outside the benchmarking loo…
a10c575 
…ps and used uniform instead of randu

Signed-off-by: ekambains <[email protected]>
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Feb 7, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 7, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/rayleigh/cdf $\color{green}288/288$
$\color{green}+100.00\%$ 		$\color{green}27/27$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}288/288$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter
chore: update maximum value
7e1e46e 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 8, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 8, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 8, 2025 •
edited by Planeshifter
Loading

PR Commit Message

chore: refactor random number generation in `stats/base/dists/rayleigh`

PR-URL: https://github.com/stdlib-js/stdlib/pull/5104
Closes: https://github.com/stdlib-js/stdlib/issues/4985

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: ekambains <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter changed the title rayleigh: Refactor random number generation in stats/base/dists/rayleigh chore: refactor random number generation in stats/base/dists/rayleigh Feb 8, 2025
@Planeshifter Planeshifter merged commit d8c1025 into stdlib-js:develop Feb 8, 2025
10 checks passed
@ekambains ekambains deleted the rayleigh-benchmarks branch February 10, 2025 05:02
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
@ekambains @Planeshifter @saurabhraghuvanshii
chore: refactor random number generation in stats/base/dists/rayleigh
2dd138c 
PR-URL: stdlib-js#5104
Closes: stdlib-js#4985

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: ekambains <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/rayleigh
3 participants
@ekambains @stdlib-bot @Planeshifter