Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add strided and assign APIs to complex/float32/base/add #5197

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

feat: add strided and assign APIs to complex/float32/base/add #5197

wants to merge 9 commits into from

Conversation

ShabiShett07
Copy link
Contributor

Resolves #5196

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Feb 11, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 11, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
complex/float32/base/add $\color{green}302/302$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}302/302$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Feb 16, 2025
@kgryte kgryte changed the title feat: add strided and assign support for /complex/float32/base/add feat: add strided and assign APIs to complex/float32/base/add Feb 16, 2025
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. labels Feb 16, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 19, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 19, 2025
@ShabiShett07
fix: update test.strided.js
6bec234 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
Copy link
Contributor Author

@Neerajpathak07 could you help me out with the CI errors?

@Neerajpathak07
Copy link
Contributor 

Error: Cannot find module '@stdlib/assert/is-same-Float32Array'

  • For starters checkout if this latter exists in the repo or not.

  • For Lint errors most of them are based on needing a newline at the end of the file. The details should provide a brief overview to it.

Neerajpathak07
Neerajpathak07 reviewed Feb 19, 2025
View reviewed changes
lib/node_modules/@stdlib/complex/float32/base/add/test/test.strided.js
expected = new Float32Array( [ 3.0, 4.0 ] );

t.deepEqual( v, out, 'returns expected value' );
t.deepEqual( isSameFloat32Array( out, expected ), true, 'returns expected value' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It takes a toll on the tests for all of the tests which have isSameFloat32Array() function as the input. So resolving this should make the tests run clean.

@Neerajpathak07
Copy link
Contributor

Neerajpathak07 commented Feb 19, 2025 •
edited
Loading

@ShabiShett07 ahh understood where the problem should lie so the latter does exist but it appears you have made a typo the correct module should be :- @stdlib/assert/is-same-float32array
This should resolve the error. LMK if it still persists.

@ShabiShett07
fix: update test.assign.js
4d5b8f9 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
fix: update test.assign.js
b1de61d 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
fix: update test.strided.js
6de0449 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
Copy link
Contributor Author

Thank you @Neerajpathak07, this solved my error.

@ShabiShett07 ShabiShett07 marked this pull request as ready for review February 20, 2025 07:02
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 20, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 20, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neerajpathak07 Neerajpathak07 Neerajpathak07 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add strided and assign support for complex/float32/base/add
4 participants
@ShabiShett07 @stdlib-bot @Neerajpathak07 @kgryte