Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: address commit comments #5248

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

chore: address commit comments #5248

wants to merge 1 commit into from

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Feb 16, 2025

type: pre_push_report
description: Results of running various checks prior to pushing changes. report:

  • task: run_javascript_examples status: na
  • task: run_c_examples status: na
  • task: run_cpp_examples status: na
  • task: run_javascript_readme_examples status: na
  • task: run_c_benchmarks status: na
  • task: run_cpp_benchmarks status: na
  • task: run_fortran_benchmarks status: na
  • task: run_javascript_benchmarks status: na
  • task: run_julia_benchmarks status: na
  • task: run_python_benchmarks status: na
  • task: run_r_benchmarks status: na
  • task: run_javascript_tests status: na ---

Resolves #5236 .

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issue.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@hrshya
chore: Address commit comment
f96b820 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 16, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/uniform/ctor $\color{green}479/479$
$\color{green}+100.00\%$ 		$\color{green}43/43$
$\color{green}+100.00\%$ 		$\color{green}18/18$
$\color{green}+100.00\%$ 		$\color{green}479/479$
$\color{green}+100.00\%$
stats/base/dists/uniform/pdf $\color{green}287/287$
$\color{green}+100.00\%$ 		$\color{green}25/25$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}287/287$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@hrshya hrshya changed the title chore: Address commit comment chore: address commit comment Feb 16, 2025
@hrshya hrshya marked this pull request as draft February 16, 2025 11:45
@hrshya hrshya marked this pull request as ready for review February 16, 2025 11:45
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Feb 16, 2025
kgryte
kgryte reviewed Feb 18, 2025
View reviewed changes
lib/node_modules/@stdlib/stats/base/dists/uniform/pdf/benchmark/benchmark.js
for ( i = 0; i < len; i++ ) {
max[i] = uniform(1, min[i], min[i] + 40.0)[0];
max[ i ] = uniform( 1, min[ i ], min[ i ] + 40.0 )[ 0 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fully address the commit comment. We don't actually need a loop here.

@kgryte kgryte changed the title chore: address commit comment chore: address commit comments Feb 18, 2025
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Needs Changes Pull request which needs changes before being merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 273d9f1)
3 participants
@hrshya @stdlib-bot @kgryte