From 457d086447cf85086a7bdbdc7079b82f998014d7 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 6 Sep 2026 02:16:18 +0000 Subject: [PATCH 1/2] test: migrate `stats/base/dists/logistic/pdf` to ULP-based assertions Ref: https://github.com/stdlib-js/stdlib/issues/11352 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01N5UvaSs85zP3Le1hoAaHvK --- .../dists/logistic/pdf/test/test.factory.js | 32 +++---------------- .../dists/logistic/pdf/test/test.native.js | 32 +++---------------- .../base/dists/logistic/pdf/test/test.pdf.js | 32 +++---------------- 3 files changed, 12 insertions(+), 84 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.factory.js index 6855e502062d..2b35a87d94d6 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.factory.js @@ -22,7 +22,7 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); var EPS = require( '@stdlib/constants/float64/eps' ); @@ -156,9 +156,7 @@ tape( 'if `s` equals `0`, the created function evaluates a degenerate distributi tape( 'the created function evaluates the pdf for `x` given positive `mu`', function test( t ) { var expected; - var delta; var pdf; - var tol; var mu; var s; var x; @@ -173,13 +171,7 @@ tape( 'the created function evaluates the pdf for `x` given positive `mu`', func pdf = factory( mu[i], s[i] ); y = pdf( x[i] ); if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } } t.end(); @@ -187,9 +179,7 @@ tape( 'the created function evaluates the pdf for `x` given positive `mu`', func tape( 'the created function evaluates the pdf for `x` given negative `mu`', function test( t ) { var expected; - var delta; var pdf; - var tol; var mu; var s; var x; @@ -204,13 +194,7 @@ tape( 'the created function evaluates the pdf for `x` given negative `mu`', func pdf = factory( mu[i], s[i] ); y = pdf( x[i] ); if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } } t.end(); @@ -218,9 +202,7 @@ tape( 'the created function evaluates the pdf for `x` given negative `mu`', func tape( 'the created function evaluates the pdf for `x` given large variance ( = large `s`)', function test( t ) { var expected; - var delta; var pdf; - var tol; var mu; var s; var x; @@ -235,13 +217,7 @@ tape( 'the created function evaluates the pdf for `x` given large variance ( = l pdf = factory( mu[i], s[i] ); y = pdf( x[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.native.js index 3c3b316f4c75..f51654bb1ddd 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.native.js @@ -24,7 +24,7 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); var EPS = require( '@stdlib/constants/float64/eps' ); @@ -122,8 +122,6 @@ tape( 'if provided `s` equal to `0`, the function evaluates a degenerate distrib tape( 'the function evaluates the pdf for `x` given positive `mu`', opts, function test( t ) { var expected; - var delta; - var tol; var mu; var x; var s; @@ -137,13 +135,7 @@ tape( 'the function evaluates the pdf for `x` given positive `mu`', opts, functi for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], mu[i], s[i] ); if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } } t.end(); @@ -151,8 +143,6 @@ tape( 'the function evaluates the pdf for `x` given positive `mu`', opts, functi tape( 'the function evaluates the pdf for `x` given negative `mu`', opts, function test( t ) { var expected; - var delta; - var tol; var mu; var x; var s; @@ -166,13 +156,7 @@ tape( 'the function evaluates the pdf for `x` given negative `mu`', opts, functi for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], mu[i], s[i] ); if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } } t.end(); @@ -180,8 +164,6 @@ tape( 'the function evaluates the pdf for `x` given negative `mu`', opts, functi tape( 'the function evaluates the pdf for `x` given large variance ( = large `s` )', opts, function test( t ) { var expected; - var delta; - var tol; var mu; var x; var s; @@ -195,13 +177,7 @@ tape( 'the function evaluates the pdf for `x` given large variance ( = large `s` for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], mu[i], s[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } } t.end(); diff --git a/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.pdf.js b/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.pdf.js index a2fb06d970c8..8ec1ebd190a2 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.pdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.pdf.js @@ -22,7 +22,7 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var PINF = require( '@stdlib/constants/float64/pinf' ); var NINF = require( '@stdlib/constants/float64/ninf' ); var EPS = require( '@stdlib/constants/float64/eps' ); @@ -113,8 +113,6 @@ tape( 'if provided `s` equal to `0`, the function evaluates a degenerate distrib tape( 'the function evaluates the pdf for `x` given positive `mu`', function test( t ) { var expected; - var delta; - var tol; var mu; var x; var s; @@ -128,13 +126,7 @@ tape( 'the function evaluates the pdf for `x` given positive `mu`', function tes for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], mu[i], s[i] ); if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } } t.end(); @@ -142,8 +134,6 @@ tape( 'the function evaluates the pdf for `x` given positive `mu`', function tes tape( 'the function evaluates the pdf for `x` given negative `mu`', function test( t ) { var expected; - var delta; - var tol; var mu; var x; var s; @@ -157,13 +147,7 @@ tape( 'the function evaluates the pdf for `x` given negative `mu`', function tes for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], mu[i], s[i] ); if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } } t.end(); @@ -171,8 +155,6 @@ tape( 'the function evaluates the pdf for `x` given negative `mu`', function tes tape( 'the function evaluates the pdf for `x` given large variance ( = large `s` )', function test( t ) { var expected; - var delta; - var tol; var mu; var x; var s; @@ -186,13 +168,7 @@ tape( 'the function evaluates the pdf for `x` given large variance ( = large `s` for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], mu[i], s[i] ); if ( expected[i] !== null ) { - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'x: '+x[i]+', mu: '+mu[i]+', s: '+s[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 3.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[ i ]+'. mu: '+mu[i]+'. s: '+s[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } } t.end(); From 282cde0e85ed4905ffc05111f84ac13bf1b8550e Mon Sep 17 00:00:00 2001 From: Athan Date: Sat, 5 Sep 2026 20:28:55 -0700 Subject: [PATCH 2/2] Apply batched suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- .../stats/base/dists/logistic/pdf/test/test.factory.js | 4 ++-- .../@stdlib/stats/base/dists/logistic/pdf/test/test.native.js | 4 ++-- .../@stdlib/stats/base/dists/logistic/pdf/test/test.pdf.js | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.factory.js b/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.factory.js index 2b35a87d94d6..d6df103e264f 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.factory.js +++ b/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.factory.js @@ -170,7 +170,7 @@ tape( 'the created function evaluates the pdf for `x` given positive `mu`', func for ( i = 0; i < x.length; i++ ) { pdf = factory( mu[i], s[i] ); y = pdf( x[i] ); - if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { + if ( expected[i] !== null && !( expected[i] === 0.0 && y < EPS ) ) { t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } } @@ -193,7 +193,7 @@ tape( 'the created function evaluates the pdf for `x` given negative `mu`', func for ( i = 0; i < x.length; i++ ) { pdf = factory( mu[i], s[i] ); y = pdf( x[i] ); - if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { + if ( expected[i] !== null && !( expected[i] === 0.0 && y < EPS ) ) { t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } } diff --git a/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.native.js index f51654bb1ddd..3f39afa568f6 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.native.js @@ -134,7 +134,7 @@ tape( 'the function evaluates the pdf for `x` given positive `mu`', opts, functi s = positiveMean.s; for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], mu[i], s[i] ); - if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { + if ( expected[i] !== null && !( expected[i] === 0.0 && y < EPS ) ) { t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } } @@ -155,7 +155,7 @@ tape( 'the function evaluates the pdf for `x` given negative `mu`', opts, functi s = negativeMean.s; for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], mu[i], s[i] ); - if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { + if ( expected[i] !== null && !( expected[i] === 0.0 && y < EPS ) ) { t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } } diff --git a/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.pdf.js b/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.pdf.js index 8ec1ebd190a2..3c73b5226753 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.pdf.js +++ b/lib/node_modules/@stdlib/stats/base/dists/logistic/pdf/test/test.pdf.js @@ -125,7 +125,7 @@ tape( 'the function evaluates the pdf for `x` given positive `mu`', function tes s = positiveMean.s; for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], mu[i], s[i] ); - if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { + if ( expected[i] !== null && !( expected[i] === 0.0 && y < EPS ) ) { t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } } @@ -146,7 +146,7 @@ tape( 'the function evaluates the pdf for `x` given negative `mu`', function tes s = negativeMean.s; for ( i = 0; i < x.length; i++ ) { y = pdf( x[i], mu[i], s[i] ); - if ( expected[i] !== null && !(expected[i] === 0.0 && y < EPS ) ) { + if ( expected[i] !== null && !( expected[i] === 0.0 && y < EPS ) ) { t.strictEqual( isAlmostSameValue( y, expected[i], 4 ), true, 'returns expected value' ); } }