fix: responses contain label typo (#118)

* fix: typo

* chore: update helm chart version

* fix: blank lines

* fix: added one blank line

Author: AleksaBajat

charts/steadybit-extension-http/Chart.yaml

@@ -1,8 +1,8 @@
 apiVersion: v2
 name: steadybit-extension-http
 description: Steadybit action implementation to check HTTP endpoints.
-version: 1.1.24
-appVersion: v1.0.28
+version: 1.1.25
+appVersion: v1.0.29
 home: https://www.steadybit.com/
 icon: https://steadybit-website-assets.s3.amazonaws.com/logo-symbol-transparent.png
 maintainers:

charts/steadybit-extension-http/values.yaml

@@ -141,4 +141,3 @@ extraVolumes: []
 
 # extraVolumeMounts -- Additional volumeMounts to which the container will be mounted.
 extraVolumeMounts: []
-

exthttpcheck/check.go

@@ -6,13 +6,14 @@ package exthttpcheck
 
 import (
 	"fmt"
+	"net/url"
+	"sync"
+	"time"
+
 	"github.com/google/uuid"
 	"github.com/rs/zerolog/log"
 	"github.com/steadybit/action-kit/go/action_kit_api/v2"
 	"github.com/steadybit/extension-kit/extutil"
-	"net/url"
-	"sync"
-	"time"
 )
 
 var (
@@ -51,7 +52,7 @@ func prepare(request action_kit_api.PrepareActionRequestBody, state *HTTPCheckSt
 		}, nil
 	}
 	state.ExpectedStatusCodes = expectedStatusCodes
-	state.ResponsesContains = extutil.ToString(request.Config["responsesContains"])
+	state.ResponsesContains = extutil.ToString(request.Config["responsesContain"])
 	state.SuccessRate = extutil.ToInt(request.Config["successRate"])
 	state.ResponseTimeMode = extutil.ToString(request.Config["responseTimeMode"])
 	state.ResponseTime = extutil.Ptr(time.Duration(extutil.ToInt64(request.Config["responseTime"])) * time.Millisecond)

exthttpcheck/check_test.go

@@ -5,15 +5,16 @@
 package exthttpcheck
 
 import (
+	"net/url"
+	"sync/atomic"
+	"testing"
+	"time"
+
 	"github.com/google/uuid"
 	"github.com/steadybit/action-kit/go/action_kit_api/v2"
 	extension_kit "github.com/steadybit/extension-kit"
 	"github.com/steadybit/extension-kit/extutil"
 	"github.com/stretchr/testify/assert"
-	"net/url"
-	"sync/atomic"
-	"testing"
-	"time"
 )
 
 func TestAction_Prepare(t *testing.T) {
@@ -30,19 +31,19 @@ func TestAction_Prepare(t *testing.T) {
 			name: "Should return config",
 			requestBody: extutil.JsonMangle(action_kit_api.PrepareActionRequestBody{
 				Config: map[string]interface{}{
-					"action":            "prepare",
-					"duration":          5000,
-					"statusCode":        "200-209",
-					"responsesContains": "test",
-					"successRate":       100,
-					"maxConcurrent":     10,
-					"numberOfRequests":  5,
-					"readTimeout":       5000,
-					"body":              "test",
-					"url":               "https://steadybit.com",
-					"method":            "GET",
-					"connectTimeout":    5000,
-					"followRedirects":   true,
+					"action":           "prepare",
+					"duration":         5000,
+					"statusCode":       "200-209",
+					"responsesContain": "test",
+					"successRate":      100,
+					"maxConcurrent":    10,
+					"numberOfRequests": 5,
+					"readTimeout":      5000,
+					"body":             "test",
+					"url":              "https://steadybit.com",
+					"method":           "GET",
+					"connectTimeout":   5000,
+					"followRedirects":  true,
 					"headers": []any{
 						map[string]any{"key": "test", "value": "test"},
 					},
@@ -83,17 +84,17 @@ func TestAction_Prepare(t *testing.T) {
 			name: "Should return error for missing url",
 			requestBody: extutil.JsonMangle(action_kit_api.PrepareActionRequestBody{
 				Config: map[string]interface{}{
-					"action":            "prepare",
-					"statusCode":        "200-209",
-					"responsesContains": "test",
-					"successRate":       100,
-					"maxConcurrent":     10,
-					"numberOfRequests":  5,
-					"readTimeout":       5000,
-					"body":              "test",
-					"method":            "GET",
-					"connectTimeout":    5000,
-					"followRedirects":   true,
+					"action":           "prepare",
+					"statusCode":       "200-209",
+					"responsesContain": "test",
+					"successRate":      100,
+					"maxConcurrent":    10,
+					"numberOfRequests": 5,
+					"readTimeout":      5000,
+					"body":             "test",
+					"method":           "GET",
+					"connectTimeout":   5000,
+					"followRedirects":  true,
 					"headers": []any{
 						map[string]any{"key": "test", "value": "test"},
 					},

exthttpcheck/common.go

@@ -133,9 +133,9 @@ var (
 		Required:     extutil.Ptr(true),
 		Order:        extutil.Ptr(12),
 	}
-	responsesContains = action_kit_api.ActionParameter{
-		Name:        "responsesContains",
-		Label:       "Responses contains",
+	responsesContain = action_kit_api.ActionParameter{
+		Name:        "responsesContain",
+		Label:       "Responses contain",
 		Description: extutil.Ptr("The responses must contain the given string, otherwise the step will fail."),
 		Type:        action_kit_api.ActionParameterTypeString,
 		Required:    extutil.Ptr(false),

exthttpcheck/fixAmount.go

@@ -7,6 +7,7 @@ package exthttpcheck
 import (
 	"context"
 	"errors"
+
 	"github.com/google/uuid"
 	"github.com/rs/zerolog/log"
 	"github.com/steadybit/action-kit/go/action_kit_api/v2"
@@ -112,7 +113,7 @@ func (l *httpCheckActionFixedAmount) Describe() action_kit_api.ActionDescription
 			resultVerification,
 			successRate,
 			statusCode,
-			responsesContains,
+			responsesContain,
 			responseTimeMode,
 			responseTime,
 			separator(16),