-
Notifications
You must be signed in to change notification settings - Fork 47
e2e tests: use quickstart workflow from non forked repo #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sreuland
wants to merge
27
commits into
main
Choose a base branch
from
use_quickstart_pipe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… will just reference local docker repo for image when forked pr
Contributor
Author
|
done testing the forked repo workflows, closing. |
Contributor
Author
|
need to test gha caching from non-forked pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changed e2e to use new system-test callable workflow.
Why
this will speed up the build time for e2e as the system-test workflow uses quickstart build pipeline and caches it's own cli and system-test images per component versions on e2e.yml when non-forked repo pr's.
using this pr to test the non-forked repo pr workflow on gha, the forked repo pr workflow is being tested on this other #520, I will close this pr once done testing.