Skip to content

bug: Length of undefined in stencil-core/angular-wrapper breaks js execution #6747

@kleitensV

Description

@kleitensV

Prerequisites

Stencil Version

Latest

Current Behavior

Between 4.41.1 and 4.41.2 value handling was changed only primitive values are allowed now.
Issue still persists in latest stencil.
The issue is that the length of undefined error is not descriptive. Also that it was broken in the patch version.
The way I fixed it in the components is added a values check to convert to string. What's the suggested approach to handle those issues.

Angular wrapper ignores the v4.41.1 error but v 4.41.2 breaks the angular ui. Error still persists in latest version.

Example in

Expected Behavior

  1. Throw an error so js execution doesnt break ui for angular wrapper.
  2. Just convert to string by default, maybe. Opened for discussion

System Info

pnpm >11
stencil-core 4.43.5
angular-output-targets 1.3.1

Steps to Reproduce

Now it's using v 4.41.2 stencil core. Rebuild angular app and press reload (length of undefined error in console in stencil core)
Change to v 4.41.1 of stencil core. Rebuild app and press reload(no error in console in angular wrapper)

It can be reproduced in vanilla stencil component
Build project and npm run start:stencil:dev the press reload button.
in v4.41.1 you get undefined error which doesnt break js execution.
in v4.41.2 you get length of undefined and js execution breaks.

Code Reproduction URL

johnjenkins/stencil-angular-starter#3

Additional Information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bug: ValidatedThis PR or Issue is verified to be a bug within Stencil

    Type

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions