Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static code analysis #6

Open
steveh250 opened this issue Oct 28, 2020 · 2 comments
Open

Static code analysis #6

steveh250 opened this issue Oct 28, 2020 · 2 comments
Assignees
@steveh250

Comments

@steveh250
Copy link
Owner

Run through static code analysis - sonarqube? Then fix.
@steveh250 steveh250 self-assigned this Oct 28, 2020
@steveh250
Copy link
Owner Author

steveh250 commented Oct 28, 2020 •
edited
Loading

Ran Codacy analysis

Security
NOTE: First three terminate the string with \0 so will not fix.
image

Error Prone
NOTE: These have been tested - non-issues.
image

@steveh250
Copy link
Owner Author

steveh250 commented Nov 1, 2020 •
edited
Loading

Substantial changes to code related to how string handing which may address the above issues (by-product of changing to getline) - requires rerunning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steveh250 steveh250

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@steveh250